Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Side by Side Diff: fpdfsdk/src/fpdfview_embeddertest.cpp

Issue 837723009: Add tests for GetNamedDests() API. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Fix min() Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/fpdfview.cpp ('k') | testing/resources/named_dests.in » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 PDFium Authors. All rights reserved. 1 // Copyright 2015 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits>
6 #include <string>
7
5 #include "../../testing/embedder_test.h" 8 #include "../../testing/embedder_test.h"
9 #include "../../fpdfsdk/include/fpdfview.h"
6 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
7 11
8 class FPDFViewEmbeddertest : public EmbedderTest { 12 class FPDFViewEmbeddertest : public EmbedderTest {
9 }; 13 };
10 14
11 TEST_F(FPDFViewEmbeddertest, Document) { 15 TEST_F(FPDFViewEmbeddertest, Document) {
12 EXPECT_TRUE(OpenDocument("testing/resources/about_blank.pdf")); 16 EXPECT_TRUE(OpenDocument("testing/resources/about_blank.pdf"));
13 EXPECT_EQ(1, GetPageCount()); 17 EXPECT_EQ(1, GetPageCount());
14 EXPECT_EQ(0, GetFirstPageNum()); 18 EXPECT_EQ(0, GetFirstPageNum());
15 19
(...skipping 17 matching lines...) Expand all
33 ClearFormFillEnvironment(form_handle); 37 ClearFormFillEnvironment(form_handle);
34 } 38 }
35 39
36 TEST_F(FPDFViewEmbeddertest, ViewerRef) { 40 TEST_F(FPDFViewEmbeddertest, ViewerRef) {
37 EXPECT_TRUE(OpenDocument("testing/resources/about_blank.pdf")); 41 EXPECT_TRUE(OpenDocument("testing/resources/about_blank.pdf"));
38 EXPECT_TRUE(FPDF_VIEWERREF_GetPrintScaling(document())); 42 EXPECT_TRUE(FPDF_VIEWERREF_GetPrintScaling(document()));
39 EXPECT_EQ(1, FPDF_VIEWERREF_GetNumCopies(document())); 43 EXPECT_EQ(1, FPDF_VIEWERREF_GetNumCopies(document()));
40 EXPECT_EQ(DuplexUndefined, FPDF_VIEWERREF_GetDuplex(document())); 44 EXPECT_EQ(DuplexUndefined, FPDF_VIEWERREF_GetDuplex(document()));
41 } 45 }
42 46
47 TEST_F(FPDFViewEmbeddertest, NamedDests) {
48 EXPECT_TRUE(OpenDocument("testing/resources/named_dests.pdf"));
49 long buffer_size;
50 char fixed_buffer[512];
51 FPDF_DEST dest;
52
53 // Query the size of the first item.
54 buffer_size = 2000000; // Absurdly large, check not used for this case.
55 dest = FPDF_GetNamedDest(document(), 0, nullptr, buffer_size);
56 EXPECT_NE(nullptr, dest);
57 EXPECT_EQ(12u, buffer_size);
58
59 // Try to retrieve the first item with too small a buffer.
60 buffer_size = 10;
61 dest = FPDF_GetNamedDest(document(), 0, fixed_buffer, buffer_size);
62 EXPECT_NE(nullptr, dest);
63 EXPECT_EQ(-1, buffer_size);
64
65 // Try to retrieve the first item with correctly sized buffer. Item is
66 // taken from Dests NameTree in named_dests.pdf.
67 buffer_size = 12;
68 dest = FPDF_GetNamedDest(document(), 0, fixed_buffer, buffer_size);
69 EXPECT_NE(nullptr, dest);
70 EXPECT_EQ(12u, buffer_size);
71 EXPECT_EQ(std::string("F\0i\0r\0s\0t\0\0\0", 12),
72 std::string(fixed_buffer, buffer_size));
73
74 // Try to retrieve the second item with ample buffer. Item is taken
75 // from Dests NameTree but has a sub-dictionary in named_dests.pdf.
76 buffer_size = sizeof(fixed_buffer);
77 dest = FPDF_GetNamedDest(document(), 1, fixed_buffer, buffer_size);
78 EXPECT_NE(nullptr, dest);
79 EXPECT_EQ(10u, buffer_size);
80 EXPECT_EQ(std::string("N\0e\0x\0t\0\0\0", 10),
81 std::string(fixed_buffer, buffer_size));
82
83 // Try to retrieve third item with ample buffer. Item is taken
84 // from Dests NameTree but has a bad sub-dictionary in named_dests.pdf.
85 // in named_dests.pdf).
86 buffer_size = sizeof(fixed_buffer);
87 dest = FPDF_GetNamedDest(document(), 2, fixed_buffer, buffer_size);
88 EXPECT_EQ(nullptr, dest);
89 EXPECT_EQ(sizeof(fixed_buffer), buffer_size); // unmodified.
90
91 // Try to retrieve the forth item with ample buffer. Item is taken
92 // from Dests NameTree but has a vale of the wrong type in named_dests.pdf.
93 buffer_size = sizeof(fixed_buffer);
94 dest = FPDF_GetNamedDest(document(), 3, fixed_buffer, buffer_size);
95 EXPECT_EQ(nullptr, dest);
96 EXPECT_EQ(sizeof(fixed_buffer), buffer_size); // unmodified.
97
98 // Try to retrieve fifth item with ample buffer. Item taken from the
99 // old-style Dests dictionary object in named_dests.pdf.
100 buffer_size = sizeof(fixed_buffer);
101 dest = FPDF_GetNamedDest(document(), 4, fixed_buffer, buffer_size);
102 EXPECT_NE(nullptr, dest);
103 EXPECT_EQ(30u, buffer_size);
104 EXPECT_EQ(
105 std::string("F\0i\0r\0s\0t\0A\0l\0t\0e\0r\0n\0a\0t\0e\0\0\0", 30),
106 std::string(fixed_buffer, buffer_size));
107
108 // Try to retrieve sixth item with ample buffer. Item istaken from the
109 // old-style Dests dictionary object but has a sub-dictionary in
110 // named_dests.pdf.
111 buffer_size = sizeof(fixed_buffer);
112 dest = FPDF_GetNamedDest(document(), 5, fixed_buffer, buffer_size);
113 EXPECT_NE(nullptr, dest);
114 EXPECT_EQ(28u, buffer_size);
115 EXPECT_EQ(
116 std::string("L\0a\0s\0t\0A\0l\0t\0e\0r\0n\0a\0t\0e\0\0\0", 28),
117 std::string(fixed_buffer, buffer_size));
118
119 // Try to retrieve non-existent item with ample buffer.
120 buffer_size = sizeof(fixed_buffer);
121 dest = FPDF_GetNamedDest(document(), 6, fixed_buffer, buffer_size);
122 EXPECT_EQ(nullptr, dest);
123 EXPECT_EQ(sizeof(fixed_buffer), buffer_size); // unmodified.
124
125 // Try to underflow/overflow the integer index.
126 buffer_size = sizeof(fixed_buffer);
127 dest = FPDF_GetNamedDest(document(), std::numeric_limits<int>::max(),
128 fixed_buffer, buffer_size);
129 EXPECT_EQ(nullptr, dest);
130 EXPECT_EQ(sizeof(fixed_buffer), buffer_size); // unmodified.
131
132 buffer_size = sizeof(fixed_buffer);
133 dest = FPDF_GetNamedDest(document(), std::numeric_limits<int>::min(),
134 fixed_buffer, buffer_size);
135 EXPECT_EQ(nullptr, dest);
136 EXPECT_EQ(sizeof(fixed_buffer), buffer_size); // unmodified.
137
138 buffer_size = sizeof(fixed_buffer);
139 dest = FPDF_GetNamedDest(document(), -1, fixed_buffer, buffer_size);
140 EXPECT_EQ(nullptr, dest);
141 EXPECT_EQ(sizeof(fixed_buffer), buffer_size); // unmodified.
142 }
OLDNEW
« no previous file with comments | « fpdfsdk/src/fpdfview.cpp ('k') | testing/resources/named_dests.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698