Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 837723006: Steps towards unification of number bitset and range types. (Closed)

Created:
5 years, 11 months ago by rossberg
Modified:
5 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Steps towards unification of number bitset and range types. - New invariant on union types: if the union has a range then the number bits in the bitset must be cleared. - Various tweaks in intersection and union to satisfy the invariant. - Exposed and used representation bits in range types (and the Limits helper class). - Implemented Glb for ranges so that the Is predicate handles ranges correctly. - Change typer weakening so that it does not rely on GetRange. However, the code still seems to be a bit fragile. - Removed the Smi types from the type system core, instead introduced Signed31, Unsigned30 and created constructors for Small(Un)Signed that point to the right type for the architecture. - Punched a hole in the config to be able to get to the isolate so that it is possible to allocate heap numbers for newly created ranges. Patch by jarin@chromium.prg, original review here: https://codereview.chromium.org/795713003/ TBR=jarin@chromium.org BUG= Committed: https://crrev.com/2764fd8d1a266a9136c987c2483492113b0c8d80 Cr-Commit-Position: refs/heads/master@{#26197}

Patch Set 1 #

Patch Set 2 : Fixed Win & clang compile issues and nits #

Patch Set 3 : Fix tests #

Patch Set 4 : Style warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -250 lines) Patch
M src/compiler/change-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/typer.cc View 2 chunks +44 lines, -33 lines 0 comments Download
M src/types.h View 1 14 chunks +82 lines, -62 lines 0 comments Download
M src/types.cc View 1 19 chunks +316 lines, -93 lines 0 comments Download
M src/types-inl.h View 1 3 chunks +19 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 2 chunks +14 lines, -18 lines 0 comments Download
M test/cctest/test-types.cc View 1 2 3 7 chunks +35 lines, -36 lines 0 comments Download
M test/cctest/types-fuzz.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837723006/20001
5 years, 11 months ago (2015-01-20 15:58:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837723006/40001
5 years, 11 months ago (2015-01-21 11:46:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2238)
5 years, 11 months ago (2015-01-21 11:52:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837723006/60001
5 years, 11 months ago (2015-01-21 12:02:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/840)
5 years, 11 months ago (2015-01-21 13:00:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837723006/60001
5 years, 11 months ago (2015-01-21 14:59:27 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-21 15:29:16 UTC) #14
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/2764fd8d1a266a9136c987c2483492113b0c8d80 Cr-Commit-Position: refs/heads/master@{#26197}
5 years, 11 months ago (2015-01-21 15:29:30 UTC) #15
Benedikt Meurer
5 years, 11 months ago (2015-01-22 05:32:50 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/868583002/ by bmeurer@chromium.org.

The reason for reverting is: Breaks test-types/Maybe, i.e.

out/Release/cctest --random-seed=-707413401 test-types/Maybe

started failing afterwards.

Powered by Google App Engine
This is Rietveld 408576698