Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 837693002: Rename SkDrawPictureCallback to SkAbortCallback (Closed)

Created:
5 years, 11 months ago by robertphillips
Modified:
5 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename SkDrawPictureCallback to SkAbortCallback

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -35 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A include/core/SkAbortCallback.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
M include/core/SkDrawPictureCallback.h View 2 chunks +8 lines, -5 lines 0 comments Download
M include/core/SkPicture.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkPicture.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPictureData.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkPicturePlayback.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M src/core/SkRecordDraw.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 6 chunks +6 lines, -5 lines 0 comments Download
M tests/RecordDrawTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
robertphillips
5 years, 11 months ago (2015-01-06 14:35:15 UTC) #2
reed1
no strong feeling, but a callback class for a single method in a single class, ...
5 years, 11 months ago (2015-01-06 15:54:15 UTC) #3
robertphillips
On 2015/01/06 15:54:15, reed1 wrote: > no strong feeling, but a callback class for a ...
5 years, 11 months ago (2015-01-06 16:25:47 UTC) #4
reed1
lgtm
5 years, 11 months ago (2015-01-06 16:33:16 UTC) #5
robertphillips
Actually it's not so bad. PTAL at https://codereview.chromium.org/829983003/
5 years, 11 months ago (2015-01-06 16:40:30 UTC) #6
robertphillips
5 years, 11 months ago (2015-01-06 17:38:10 UTC) #7
Message was sent while issue was closed. 
Closed in favor of: https://codereview.chromium.org/829983003/

Powered by Google App Engine
This is Rietveld 408576698