Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 837573003: Chromecast: adds disable_display define for headless builds. (Closed)

Created:
5 years, 11 months ago by gunsch
Modified:
5 years, 11 months ago
Reviewers:
lcwu1
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: adds disable_display define for headless builds. Headless builds should include a few optimizations by default: * Force-disabling GPU * Not loading image resources R=lcwu@chromium.org BUG=336640 Committed: https://crrev.com/a4b98fb5b518e886851131916816c0b607768392 Cr-Commit-Position: refs/heads/master@{#310546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M chromecast/browser/cast_browser_main_parts.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chromecast/chromecast.gyp View 2 chunks +6 lines, -0 lines 0 comments Download
M chromecast/chromecast_tests.gypi View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
gunsch
5 years, 11 months ago (2015-01-06 01:25:09 UTC) #1
lcwu1
lgtm
5 years, 11 months ago (2015-01-08 18:35:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837573003/1
5 years, 11 months ago (2015-01-08 18:37:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-08 18:53:21 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 18:54:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4b98fb5b518e886851131916816c0b607768392
Cr-Commit-Position: refs/heads/master@{#310546}

Powered by Google App Engine
This is Rietveld 408576698