Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 837573002: Temporarily disable the OilpanGCTimesTest to unblock the Blink roll. (Closed)

Created:
5 years, 11 months ago by dglazkov
Modified:
5 years, 11 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disable the OilpanGCTimesTest to unblock the Blink roll. BUG=446301 R=tonyg@chromium.org, tonyg Committed: https://chromium.googlesource.com/chromium/src/+/d4f2289a66f4f74d862a27554ccb1d334831cb3a

Patch Set 1 #

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tools/perf/benchmarks/oilpan_gc_times.py View 1 2 chunks +4 lines, -3 lines 0 comments Download
M tools/perf/measurements/oilpan_gc_times_unittest.py View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
dglazkov
5 years, 11 months ago (2015-01-05 23:13:31 UTC) #1
tonyg
I believe we also have to disable the benchmarks themselves in tools/perf/benchmarks/oilpan_gc_times.py. These are the ...
5 years, 11 months ago (2015-01-05 23:15:27 UTC) #2
dglazkov
On 2015/01/05 at 23:15:27, tonyg wrote: > I believe we also have to disable the ...
5 years, 11 months ago (2015-01-05 23:26:55 UTC) #3
dglazkov
5 years, 11 months ago (2015-01-05 23:27:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837573002/20001
5 years, 11 months ago (2015-01-05 23:28:29 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d4f2289a66f4f74d862a27554ccb1d334831cb3a Cr-Commit-Position: refs/heads/master@{#310003}
5 years, 11 months ago (2015-01-05 23:55:07 UTC) #7
dglazkov
5 years, 11 months ago (2015-01-05 23:58:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d4f2289a66f4f74d862a27554ccb1d334831cb3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698