Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 837533002: cc: Re-enable prepaint for GPU rasterization (Closed)

Created:
5 years, 11 months ago by hendrikw
Modified:
5 years, 11 months ago
Reviewers:
vmpstr, vmiura
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Re-enable prepaint for GPU rasterization The synchronous rasterization change for GPU rasterization tries to avoid prepainting, which may have caused longer frame times in some of the tests. We'll re-enable prepainting to see if this is the reason. This will probably be reverted. Committed: https://crrev.com/dee056c614737f8bf07686d38dfcc4d264c51813 Cr-Commit-Position: refs/heads/master@{#309956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M cc/resources/tile_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/tile_manager.cc View 6 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
hendrikw
PTAL
5 years, 11 months ago (2015-01-05 18:45:29 UTC) #2
vmiura
On 2015/01/05 18:45:29, hendrikw wrote: > PTAL LGTM.
5 years, 11 months ago (2015-01-05 18:58:16 UTC) #3
vmpstr
lgtm
5 years, 11 months ago (2015-01-05 19:29:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837533002/1
5 years, 11 months ago (2015-01-05 19:31:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-05 20:32:52 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dee056c614737f8bf07686d38dfcc4d264c51813 Cr-Commit-Position: refs/heads/master@{#309956}
5 years, 11 months ago (2015-01-05 20:33:36 UTC) #8
hendrikw
On 2015/01/05 20:33:36, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 11 months ago (2015-01-07 23:21:34 UTC) #9
hendrikw
5 years, 11 months ago (2015-01-07 23:22:34 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/844503004/ by hendrikw@chromium.org.

The reason for reverting is: Better to leave this in, and now we know that this
doesn't improve telemetry significantly.

Powered by Google App Engine
This is Rietveld 408576698