Fix an array size mismatch.

Fix an array size mismatch.

The g_UnicodeData_Normalization_Map2 array is initialized with a size of
1724 in core\src\fpdftext\unicodenormalizationdata.cpp but its size is
1734 (+10) in core\src\fpdftext\unicodenormalization.cpp, 1724 seems to be
the real size (i.e. there's 1724 values in the initialization list).

BUG=446057

[Sébastien Marchand, 2015-01-05 15:59:48]

sebmarchand@chromium.org changed reviewers:
+ jam@chromium.org

[Sébastien Marchand, 2015-01-05 15:59:48]

PTAL.

[aarya, 2015-01-05 16:13:50]

aarya@google.com changed reviewers:
+ bo_xu@foxitsoftware.com, jun_fang@foxitsoftware.com

[inferno, 2015-01-05 16:21:47]

inferno@chromium.org changed reviewers:
+ inferno@chromium.org

[inferno, 2015-01-05 16:21:48]

The CQ bit was checked by inferno@chromium.org

[inferno, 2015-01-05 16:21:48]

lgtm

[commit-bot: I haz the power, 2015-01-05 16:25:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-05 16:25:53]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Lei Zhang, 2015-01-05 22:35:06]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-01-05 22:35:06]

Landing for you here: https://codereview.chromium.org/812843004/

[brucedawson, 2015-01-05 22:46:52]

Putting declarations of arrays in CPP files is quite dangerous -- there is no
easy way to tell whether the sizes are correct and the compilers we use offer no
help in validating the sizes. I think that as a long-term fix we should consider
moving these declarations to a header file so that they are visible at the same
time as the definitions, thus ensuring that the compiler will point out any
discrepancies.

Alternately, since the sizes are not actually needed by
unicodenormalization.cpp, they could just be removed from those declarations.

[Lei Zhang, 2015-01-05 23:11:22]

On 2015/01/05 22:46:52, brucedawson wrote:
> Putting declarations of arrays in CPP files is quite dangerous -- there is no
> easy way to tell whether the sizes are correct and the compilers we use offer
no
> help in validating the sizes. I think that as a long-term fix we should
consider
> moving these declarations to a header file so that they are visible at the
same
> time as the definitions, thus ensuring that the compiler will point out any
> discrepancies.
> 
> Alternately, since the sizes are not actually needed by
> unicodenormalization.cpp, they could just be removed from those declarations.

Sure: https://codereview.chromium.org/825983004

[Sébastien Marchand, 2015-01-06 15:45:17]

Thanks for landing this one for me and for the follow up on it (825983004).

Should we roll deps now ?