Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: tools/perf/measurements/startup.py

Issue 837483004: Revert of [Telemetry] Remove empty action_name_to_run for Startup, SessionRestore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/measurements/session_restore.py ('k') | tools/perf/page_sets/typical_25.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from metrics import startup_metric 5 from metrics import startup_metric
6 from telemetry.page import page_test 6 from telemetry.page import page_test
7 7
8 8
9 class Startup(page_test.PageTest): 9 class Startup(page_test.PageTest):
10 """Performs a measurement of Chromium's startup performance. 10 """Performs a measurement of Chromium's startup performance.
11 11
12 Uses cold start if cold==True, otherwise uses warm start. A cold start means 12 Uses cold start if cold==True, otherwise uses warm start. A cold start means
13 none of the Chromium files are in the disk cache. A warm start assumes the OS 13 none of the Chromium files are in the disk cache. A warm start assumes the OS
14 has already cached much of Chromium's content. For warm tests, you should 14 has already cached much of Chromium's content. For warm tests, you should
15 repeat the page set to ensure it's cached. 15 repeat the page set to ensure it's cached.
16 """ 16 """
17 17
18 def __init__(self, cold=False, action_name_to_run='RunPageInteractions'): 18 def __init__(self, cold=False, action_name_to_run=''):
19 super(Startup, self).__init__(needs_browser_restart_after_each_page=True, 19 super(Startup, self).__init__(needs_browser_restart_after_each_page=True,
20 action_name_to_run=action_name_to_run) 20 action_name_to_run=action_name_to_run)
21 self._cold = cold 21 self._cold = cold
22 22
23 def CustomizeBrowserOptions(self, options): 23 def CustomizeBrowserOptions(self, options):
24 if self._cold: 24 if self._cold:
25 options.clear_sytem_cache_for_browser_and_profile_on_start = True 25 options.clear_sytem_cache_for_browser_and_profile_on_start = True
26 else: 26 else:
27 self.discard_first_result = True 27 self.discard_first_result = True
28 28
(...skipping 17 matching lines...) Expand all
46 has already cached much of Chromium's content. For warm tests, you should 46 has already cached much of Chromium's content. For warm tests, you should
47 repeat the page set to ensure it's cached. 47 repeat the page set to ensure it's cached.
48 48
49 The startup URL is taken from the page's startup_url. This 49 The startup URL is taken from the page's startup_url. This
50 allows the testing of multiple different URLs in a single benchmark. 50 allows the testing of multiple different URLs in a single benchmark.
51 """ 51 """
52 52
53 def __init__(self, cold=False): 53 def __init__(self, cold=False):
54 super(StartWithUrl, self).__init__(cold=cold, 54 super(StartWithUrl, self).__init__(cold=cold,
55 action_name_to_run='RunPageInteractions') 55 action_name_to_run='RunPageInteractions')
OLDNEW
« no previous file with comments | « tools/perf/measurements/session_restore.py ('k') | tools/perf/page_sets/typical_25.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698