Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 837483003: [ozone] Add stub async swap buffers implementation to ozone surfaceless. (Closed)

Created:
5 years, 11 months ago by alexst (slow to review)
Modified:
5 years, 11 months ago
Reviewers:
dnicoara, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ozone] Add stub implementation to ozone surfaceless to avoid hitting the DCHECK and allow the platform implementation to handle async swap properly. BUG=445977 Committed: https://crrev.com/409e3e02bfc1d3d2b20b7a2e5eb725289cf90022 Cr-Commit-Position: refs/heads/master@{#309969}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M ui/gl/gl_surface_ozone.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surfaceless.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surfaceless.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/ozone/public/surface_ozone_egl.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alexst (slow to review)
5 years, 11 months ago (2015-01-05 17:06:02 UTC) #3
spang
lgtm https://codereview.chromium.org/837483003/diff/20001/ui/ozone/public/surface_ozone_egl.h File ui/ozone/public/surface_ozone_egl.h (right): https://codereview.chromium.org/837483003/diff/20001/ui/ozone/public/surface_ozone_egl.h#newcode42 ui/ozone/public/surface_ozone_egl.h:42: typedef base::Callback<void()> SwapCompletionCallback; base::Closure
5 years, 11 months ago (2015-01-05 19:27:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837483003/40001
5 years, 11 months ago (2015-01-05 21:39:39 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-05 22:20:54 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 22:22:33 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/409e3e02bfc1d3d2b20b7a2e5eb725289cf90022
Cr-Commit-Position: refs/heads/master@{#309969}

Powered by Google App Engine
This is Rietveld 408576698