Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 837483002: debugger: Update the picture view when the first command is selected (Closed)

Created:
5 years, 11 months ago by Kimmo Kinnunen
Modified:
5 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@debugger-small-things-03-geometry-view-pause
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

debugger: Update the picture view when the first command is selected Update the picture view in the debugger when the first command is selected. DebugCanvas::drawTo(index) draws up to and including the index. Committed: https://skia.googlesource.com/skia/+/5a2315e750f65a8b61faa509a65840c622f04424

Patch Set 1 #

Patch Set 2 : missing hunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M debugger/SkDebugger.h View 1 chunk +1 line, -1 line 0 comments Download
M debugger/SkDebugger.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kimmo Kinnunen
5 years, 11 months ago (2015-01-05 12:10:53 UTC) #2
robertphillips
lgtm
5 years, 11 months ago (2015-01-05 19:41:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837483002/20001
5 years, 11 months ago (2015-01-05 19:42:20 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 19:51:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5a2315e750f65a8b61faa509a65840c622f04424

Powered by Google App Engine
This is Rietveld 408576698