Issue 83743002: Have the HTMLSelectElement setter throw TypeError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83743002: Have the HTMLSelectElement setter throw TypeError. (Closed)

Created:
7 years, 1 month ago by sof

Modified:
7 years, 1 month ago

Reviewers:
Mike West, jochen (gone - plz use gerrit)

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Have the HTMLSelectElement setter throw TypeError. If an argument that fails to convert to 'HTMLOptionElement?' is passed to the option setter/remover on HTMLSelectElement, throw TypeError. This follows WebIDL and Gecko. Other implementations don't throw, but ignore such operations. R= BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162559

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	LayoutTests/fast/dom/HTMLSelectElement/exceptions-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/html/HTMLSelectElement.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mike West

On 2013/11/22 16:26:11, sof wrote: > At your own leisure, please take a look. LGTM. ...

7 years, 1 month ago (2013-11-22 17:06:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/83743002/1

7 years, 1 month ago (2013-11-22 18:04:27 UTC) #3

Message was sent while issue was closed.

Change committed as 162559

Expand Messages | Collapse Messages