[turbofan] Cleanup duplicated/unused code in InstructionSelector.

[turbofan] Cleanup duplicated/unused code in InstructionSelector.

- Use C++11 range based for loops.
- Remove duplicated virtual register set in unittests.
- Don't expose implementation details of InstructionSelector.

TEST=unittests
R=dcarney@chromium.org

Committed: https://crrev.com/515747253989408d7e9e96cd6aa5324a0a352b0c
Cr-Commit-Position: refs/heads/master@{#25997}

[Benedikt Meurer, 2015-01-08 12:48:19]

PTAL

[dcarney, 2015-01-08 12:54:09]

lgtm

https://codereview.chromium.org/837423002/diff/1/src/compiler/instruction-sel...
File src/compiler/instruction-selector.cc (right):

https://codereview.chromium.org/837423002/diff/1/src/compiler/instruction-sel...
src/compiler/instruction-selector.cc:59: for (BasicBlock* const block : *blocks)
{
what no auto?

https://codereview.chromium.org/837423002/diff/1/src/compiler/instruction-sel...
File src/compiler/instruction-selector.h (right):

https://codereview.chromium.org/837423002/diff/1/src/compiler/instruction-sel...
src/compiler/instruction-selector.h:212: enum { kNoVirtualRegister = -1 };
this should be UnallocatedOperand::kInvalidVirtualRegister, which didn't exist
at the time this was introduced

[Benedikt Meurer, 2015-01-08 13:23:06]

https://codereview.chromium.org/837423002/diff/1/src/compiler/instruction-sel...
File src/compiler/instruction-selector.cc (right):

https://codereview.chromium.org/837423002/diff/1/src/compiler/instruction-sel...
src/compiler/instruction-selector.cc:59: for (BasicBlock* const block : *blocks)
{
On 2015/01/08 12:54:09, dcarney wrote:
> what no auto?

Done.

https://codereview.chromium.org/837423002/diff/1/src/compiler/instruction-sel...
File src/compiler/instruction-selector.h (right):

https://codereview.chromium.org/837423002/diff/1/src/compiler/instruction-sel...
src/compiler/instruction-selector.h:212: enum { kNoVirtualRegister = -1 };
On 2015/01/08 12:54:09, dcarney wrote:
> this should be UnallocatedOperand::kInvalidVirtualRegister, which didn't exist
> at the time this was introduced

Done.

[Benedikt Meurer, 2015-01-08 13:23:10]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-01-08 13:23:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/837423002/20001

[commit-bot: I haz the power, 2015-01-08 13:41:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-08 13:41:11]

Try jobs failed on following builders:
  v8_win64_rel on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/1117)

[Benedikt Meurer, 2015-01-08 13:45:15]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-01-08 13:46:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/837423002/40001

[commit-bot: I haz the power, 2015-01-08 14:13:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-08 14:13:48]

Patchset 3 (id:??) landed as
https://crrev.com/515747253989408d7e9e96cd6aa5324a0a352b0c
Cr-Commit-Position: refs/heads/master@{#25997}