Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: net/base/x509_certificate.cc

Issue 8374020: Make it a fatal SSL error when encountering certs signed with md[2,4], and interstitial md5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: wtc feedback Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/x509_certificate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/x509_certificate.cc
diff --git a/net/base/x509_certificate.cc b/net/base/x509_certificate.cc
index efb19eeb718168d8e82a215e65bf925f75eb9364..06eb6626181816e9ab7a14b0c2c095c29d26e23c 100644
--- a/net/base/x509_certificate.cc
+++ b/net/base/x509_certificate.cc
@@ -597,6 +597,22 @@ int X509Certificate::Verify(const std::string& hostname,
rv = MapCertStatusToNetError(verify_result->cert_status);
}
+ // Treat certificates signed using broken signature algorithms as invalid.
+ if (verify_result->has_md2 || verify_result->has_md4) {
+ verify_result->cert_status |= CERT_STATUS_INVALID;
+ rv = MapCertStatusToNetError(verify_result->cert_status);
+ }
+
+ // Flag certificates using weak signature algorithms.
+ if (verify_result->has_md5) {
+ verify_result->cert_status |= CERT_STATUS_WEAK_SIGNATURE_ALGORITHM;
+ // Avoid replacing a more serious error, such as an OS/library failure,
+ // by ensuring that if verification failed, it failed with a certificate
+ // error.
+ if (rv == OK || IsCertificateError(rv))
+ rv = MapCertStatusToNetError(verify_result->cert_status);
+ }
+
return rv;
}
« no previous file with comments | « no previous file | net/base/x509_certificate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698