Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1774)

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.cc

Issue 8373021: Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old U... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: take out CHECKs Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/client_side_detection_service.cc
===================================================================
--- chrome/browser/safe_browsing/client_side_detection_service.cc (revision 106795)
+++ chrome/browser/safe_browsing/client_side_detection_service.cc (working copy)
@@ -25,6 +25,7 @@
#include "chrome/common/safe_browsing/safebrowsing_messages.h"
#include "content/browser/browser_thread.h"
#include "content/browser/renderer_host/render_process_host.h"
+#include "content/common/net/url_fetcher.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
#include "crypto/sha2.h"
@@ -183,18 +184,18 @@
return false;
}
-void ClientSideDetectionService::OnURLFetchComplete(
- const URLFetcher* source,
- const GURL& url,
- const net::URLRequestStatus& status,
- int response_code,
- const net::ResponseCookies& cookies,
- const std::string& data) {
+void ClientSideDetectionService::OnURLFetchComplete(const URLFetcher* source) {
+ std::string data;
+ source->GetResponseAsString(&data);
if (source == model_fetcher_.get()) {
- HandleModelResponse(source, url, status, response_code, cookies, data);
+ HandleModelResponse(
+ source, source->url(), source->status(), source->response_code(),
+ source->cookies(), data);
} else if (client_phishing_reports_.find(source) !=
client_phishing_reports_.end()) {
- HandlePhishingVerdict(source, url, status, response_code, cookies, data);
+ HandlePhishingVerdict(
+ source, source->url(), source->status(), source->response_code(),
+ source->cookies(), data);
} else {
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698