chrome/service/gaia/service_gaia_authenticator.cc - Issue 8373021: Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old U...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/gaia/service_gaia_authenticator.cc

Issue 8373021: Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old U... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/autofill_download.cc ('K') | « chrome/service/gaia/service_gaia_authenticator.h ('k') | content/browser/geolocation/network_location_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/gaia/service_gaia_authenticator.cc

===================================================================

--- chrome/service/gaia/service_gaia_authenticator.cc (revision 106795)

+++ chrome/service/gaia/service_gaia_authenticator.cc (working copy)

@@ -7,6 +7,7 @@

#include "base/message_loop_proxy.h"

#include "chrome/service/net/service_url_request_context.h"

#include "chrome/service/service_process.h"

+#include "content/common/net/url_fetcher.h"

#include "googleurl/src/gurl.h"

ServiceGaiaAuthenticator::ServiceGaiaAuthenticator(

@@ -70,11 +71,11 @@

request->Start();

}

-// URLFetcher::Delegate implementation

+// content::URLFetcherDelegate implementation

void ServiceGaiaAuthenticator::OnURLFetchComplete(const URLFetcher* source) {

DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());

http_response_code_ = source->response_code();

- response_data_ = source->GetResponseStringRef();

+ CHECK(source->GetResponseAsString(&response_data_));

delete source;

// Add an extra reference because we want http_post_completed_ to remain

// valid until after Signal() returns.