content/browser/speech/speech_recognition_request.cc - Issue 8373021: Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old U...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/speech_recognition_request.cc

Issue 8373021: Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old U... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: sync and remove unncessary forward declares Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_service.cc ('K') | « content/browser/speech/speech_recognition_request.h ('k') | content/common/net/url_fetcher.h » ('j') | content/common/net/url_fetcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/speech_recognition_request.cc

===================================================================

--- content/browser/speech/speech_recognition_request.cc (revision 106929)

+++ content/browser/speech/speech_recognition_request.cc (working copy)

@@ -10,6 +10,7 @@

#include "base/string_number_conversions.h"

#include "base/string_util.h"

#include "base/values.h"

+#include "content/common/net/url_fetcher.h"

#include "net/base/escape.h"

#include "net/base/load_flags.h"

#include "net/url_request/url_request_context.h"

@@ -209,8 +210,10 @@

DCHECK_EQ(url_fetcher_.get(), source);

SpeechInputResult result;

+ std::string data;

if (!source->status().is_success() || source->response_code() != 200 ||

- !ParseServerResponse(source->GetResponseStringRef(), &result)) {

+ !source->GetResponseAsString(&data) ||

+ !ParseServerResponse(data, &result)) {

result.error = kErrorNetwork;

}