Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: chrome/browser/policy/testing_policy_url_fetcher_factory.cc

Issue 8373021: Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old U... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync and remove unncessary forward declares Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/testing_policy_url_fetcher_factory.cc
===================================================================
--- chrome/browser/policy/testing_policy_url_fetcher_factory.cc (revision 106929)
+++ chrome/browser/policy/testing_policy_url_fetcher_factory.cc (working copy)
@@ -40,13 +40,31 @@
const base::WeakPtr<TestingPolicyURLFetcherFactory>& parent,
const GURL& url,
URLFetcher::RequestType request_type,
- URLFetcher::Delegate* delegate);
+ content::URLFetcherDelegate* delegate);
virtual void Start() OVERRIDE;
void Respond();
+ virtual const GURL& url() const {
+ return url_;
+ }
+
+ virtual const net::URLRequestStatus& status() const {
+ return status_;
+ }
+
+ virtual int response_code() const {
+ return response_.response_code;
+ }
+
+ virtual bool GetResponseAsString(std::string* out_response_string) const {
+ *out_response_string = response_.response_data;
+ return true;
+ }
+
private:
GURL url_;
+ net::URLRequestStatus status_;
TestURLResponse response_;
base::WeakPtr<TestingPolicyURLFetcherFactory> parent_;
@@ -57,9 +75,10 @@
const base::WeakPtr<TestingPolicyURLFetcherFactory>& parent,
const GURL& url,
URLFetcher::RequestType request_type,
- URLFetcher::Delegate* delegate)
+ content::URLFetcherDelegate* delegate)
: URLFetcher(url, request_type, delegate),
url_(url),
+ status_(net::URLRequestStatus::SUCCESS, 0),
parent_(parent) {
}
@@ -82,13 +101,7 @@
}
void TestingPolicyURLFetcher::Respond() {
- delegate()->OnURLFetchComplete(
- this,
- url_,
- net::URLRequestStatus(net::URLRequestStatus::SUCCESS, 0),
- response_.response_code,
- net::ResponseCookies(),
- response_.response_data);
+ delegate()->OnURLFetchComplete(this);
}
TestingPolicyURLFetcherFactory::TestingPolicyURLFetcherFactory(
@@ -118,7 +131,7 @@
int id,
const GURL& url,
URLFetcher::RequestType request_type,
- URLFetcher::Delegate* delegate) {
+ content::URLFetcherDelegate* delegate) {
return new TestingPolicyURLFetcher(
weak_ptr_factory_.GetWeakPtr(), url, request_type, delegate);
}

Powered by Google App Engine
This is Rietveld 408576698