Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6700)

Unified Diff: chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc

Issue 8373021: Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old U... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync and remove unncessary forward declares Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc
===================================================================
--- chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc (revision 106929)
+++ chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc (working copy)
@@ -160,8 +160,14 @@
net::ResponseCookies cookies;
net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);
GURL url(GaiaUrls::GetInstance()->oauth_get_access_token_url());
- oauth_fetcher.OnURLFetchComplete(NULL, url, status, RC_REQUEST_OK,
- cookies, data);
+
+ TestURLFetcher test_fetcher(0, GURL(), URLFetcher::GET, &oauth_fetcher);
+ test_fetcher.set_url(url);
+ test_fetcher.set_status(status);
+ test_fetcher.set_response_code(RC_REQUEST_OK);
+ test_fetcher.set_cookies(cookies);
+ test_fetcher.SetResponseString(data);
+ oauth_fetcher.OnURLFetchComplete(&test_fetcher);
}
TEST_F(GaiaOAuthFetcherTest, OAuthWrapBridge) {
@@ -189,8 +195,14 @@
net::ResponseCookies cookies;
net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);
GURL url(GaiaUrls::GetInstance()->oauth_wrap_bridge_url());
- oauth_fetcher.OnURLFetchComplete(NULL, url, status, RC_REQUEST_OK,
- cookies, data);
+
+ TestURLFetcher test_fetcher(0, GURL(), URLFetcher::GET, &oauth_fetcher);
+ test_fetcher.set_url(url);
+ test_fetcher.set_status(status);
+ test_fetcher.set_response_code(RC_REQUEST_OK);
+ test_fetcher.set_cookies(cookies);
+ test_fetcher.SetResponseString(data);
+ oauth_fetcher.OnURLFetchComplete(&test_fetcher);
}
TEST_F(GaiaOAuthFetcherTest, UserInfo) {
@@ -213,8 +225,14 @@
net::ResponseCookies cookies;
net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);
GURL url(GaiaUrls::GetInstance()->oauth_user_info_url());
- oauth_fetcher.OnURLFetchComplete(NULL, url, status,
- RC_REQUEST_OK, cookies, data);
+
+ TestURLFetcher test_fetcher(0, GURL(), URLFetcher::GET, &oauth_fetcher);
+ test_fetcher.set_url(url);
+ test_fetcher.set_status(status);
+ test_fetcher.set_response_code(RC_REQUEST_OK);
+ test_fetcher.set_cookies(cookies);
+ test_fetcher.SetResponseString(data);
+ oauth_fetcher.OnURLFetchComplete(&test_fetcher);
}
TEST_F(GaiaOAuthFetcherTest, OAuthRevokeToken) {
@@ -232,6 +250,11 @@
net::ResponseCookies cookies;
net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);
GURL url(GaiaUrls::GetInstance()->oauth_revoke_token_url());
- oauth_fetcher.OnURLFetchComplete(NULL, url, status,
- RC_REQUEST_OK, cookies, std::string());
+
+ TestURLFetcher test_fetcher(0, GURL(), URLFetcher::GET, &oauth_fetcher);
+ test_fetcher.set_url(url);
+ test_fetcher.set_status(status);
+ test_fetcher.set_response_code(RC_REQUEST_OK);
+ test_fetcher.set_cookies(cookies);
+ oauth_fetcher.OnURLFetchComplete(&test_fetcher);
}

Powered by Google App Engine
This is Rietveld 408576698