chrome/browser/extensions/extension_updater.cc - Issue 8373021: Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old U...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_updater.cc

Issue 8373021: Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old U... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: sync and remove unncessary forward declares Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_updater.h ('k') | chrome/browser/extensions/webstore_inline_installer.h » ('j') | chrome/browser/metrics/metrics_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_updater.cc

===================================================================

--- chrome/browser/extensions/extension_updater.cc (revision 106929)

+++ chrome/browser/extensions/extension_updater.cc (working copy)

@@ -37,6 +37,7 @@

#include "chrome/common/extensions/extension_file_util.h"

#include "chrome/common/pref_names.h"

#include "content/browser/utility_process_host.h"

+#include "content/common/net/url_fetcher.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_source.h"

#include "crypto/sha2.h"

@@ -597,7 +598,7 @@

if (source == manifest_fetcher_.get()) {

std::string data;

- CHECK(source->GetResponseAsString(&data));

+ source->GetResponseAsString(&data);

OnManifestFetchComplete(source->url(),

source->status(),

source->response_code(),

@@ -843,7 +844,7 @@

(response_code == 200 || url.SchemeIsFile())) {

if (current_extension_fetch_.id == kBlacklistAppID) {

std::string data;

- CHECK(source->GetResponseAsString(&data));

+ source->GetResponseAsString(&data);

ProcessBlacklist(data);

in_progress_ids_.erase(current_extension_fetch_.id);

} else {