win: various porting for http_body_test.cc

win: various porting for http_body_test.cc

- Wrap constants in FILE_PATH_LITERAL for L"".
- dynamic allocation, as VS otherwise complains about lack of constant
expression:

d:\src\crashpad\crashpad\util\net\http_body_test.cc(182) : error C2057: expected constant expression
d:\src\crashpad\crashpad\util\net\http_body_test.cc(182) : error C2466: cannot allocate an array of constant size 0
d:\src\crashpad\crashpad\util\net\http_body_test.cc(182) : error C2133: 'buf' : unknown size
d:\src\crashpad\crashpad\util\net\http_body_test.cc(183) : error C2070: 'uint8_t []': illegal sizeof operand
d:\src\crashpad\crashpad\util\net\http_body_test.cc(196) : error C2070: 'uint8_t []': illegal sizeof operand

R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/119c4fdd9365e387c9c989d8d68f8f3c82ebdc5a

[Mark Mentovai, 2015-01-07 22:47:27]

LGTM

https://codereview.chromium.org/837293002/diff/1/util/net/http_body_test.cc
File util/net/http_body_test.cc (right):

https://codereview.chromium.org/837293002/diff/1/util/net/http_body_test.cc#n...
util/net/http_body_test.cc:180: const size_t all_strings_length =
We could make this constexpr, but then it’d have to be a different expression,
and that expression would be suckier.

https://codereview.chromium.org/837293002/diff/1/util/net/http_body_test.cc#n...
util/net/http_body_test.cc:182: scoped_ptr<uint8_t[]> buf(new
uint8_t[all_strings_length + 3]);
Maybe it’s more natural to make this std::string buf(all_strings_length + 3,
'!'); and lose the memset.

(And then the #include, too…looks like it was unused before you added this
scoped_ptr.)

[scottmg, 2015-01-07 22:59:58]

Patchset #2 (id:20001) has been deleted

[scottmg, 2015-01-07 23:01:12]

https://codereview.chromium.org/837293002/diff/1/util/net/http_body_test.cc
File util/net/http_body_test.cc (right):

https://codereview.chromium.org/837293002/diff/1/util/net/http_body_test.cc#n...
util/net/http_body_test.cc:180: const size_t all_strings_length =
On 2015/01/07 22:47:27, Mark Mentovai wrote:
> We could make this constexpr, but then it’d have to be a different expression,
> and that expression would be suckier.

No constexpr support in VS2013. :(

https://codereview.chromium.org/837293002/diff/1/util/net/http_body_test.cc#n...
util/net/http_body_test.cc:182: scoped_ptr<uint8_t[]> buf(new
uint8_t[all_strings_length + 3]);
On 2015/01/07 22:47:27, Mark Mentovai wrote:
> Maybe it’s more natural to make this std::string buf(all_strings_length + 3,
> '!'); and lose the memset.
> 
> (And then the #include, too…looks like it was unused before you added this
> scoped_ptr.)

Done.

[Mark Mentovai, 2015-01-07 23:03:31]

LGTM

[scottmg, 2015-01-07 23:05:45]

Committed patchset #2 (id:40001) manually as
119c4fdd9365e387c9c989d8d68f8f3c82ebdc5a (presubmit successful).