Start replicating sandbox flags for OOPIF

content/common/frame_replication_state.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_FRAME_REPLICATION_STATE_H_
 #define CONTENT_COMMON_FRAME_REPLICATION_STATE_H_
 
 #include "content/common/content_export.h"
 #include "url/origin.h"
 
 namespace content {
 
+// Must be kept in sync with blink::WebSandboxFlags.  Enforced in

[Charlie Reis, 2015/01/08 22:17:26]

We should document what this is for, since it could easily be confused with
Chrome's sandbox.

[alexmos, 2015/01/09 20:43:25]

Done.

+// render_frame_impl.cc.
+enum class SandboxFlags : int {

[alexmos, 2015/01/08 01:51:41]

Made this an "enum class" so I could forward-declare it in mock_render_thread.h,
where presubmit rules didn't let me include frame_replication_state.h.

[Charlie Reis, 2015/01/08 22:17:26]

There was a big C++11 discussion thread on this and flags, which got too
bikeshedded for me to follow:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/Q5WmkAImanc

This SGTM for the forward declare property, if there aren't issues with using it
for flags.  Let's just have dcheng verify.

[dcheng, 2015/01/09 07:56:57]

Yep, this is fine =)

+  // For a list of sandbox flags, see
+  // http://www.whatwg.org/specs/web-apps/current-work/#attr-iframe-sandbox
+  NONE = 0,
+  NAVIGATION = 1,
+  PLUGINS = 1 << 1,
+  ORIGIN = 1 << 2,
+  FORMS = 1 << 3,
+  SCRIPTS = 1 << 4,
+  TOP_NAVIGATION = 1 << 5,
+  POPUPS = 1 << 6,
+  AUTOMATIC_FEATURES = 1 << 7,
+  POINTER_LOCK = 1 << 8,
+  DOCUMENT_DOMAIN = 1 << 9,
+  ORIENTATION_LOCK = 1 << 10,
+  ALL = -1
+};
+
 // This structure holds information that needs to be replicated from a
 // RenderFrame to any of its associated RenderFrameProxies.
 struct CONTENT_EXPORT FrameReplicationState {
   FrameReplicationState();
   ~FrameReplicationState();
 
   // Current serialized security origin of the frame. Unique origins are
   // represented as the string "null" per RFC 6454.
   url::Origin origin;
 
+  // Current sandbox flags of the frame.
+  SandboxFlags sandbox_flags;
+
   // TODO(alexmos): Eventually, this structure can also hold other state that
   // needs to be replicated, such as frame sizing info.
 };
 
 }  // namespace content
 
 #endif // CONTENT_COMMON_FRAME_REPLICATION_STATE_H_