mojo/services/public/js/shell.js - Issue 837283002: Mojo JS Bindings: merge Application, Shell, ServiceProvider with Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/js/shell.js

Issue 837283002: Mojo JS Bindings: merge Application, Shell, ServiceProvider with Sky (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/services/public/js/shell.js

diff --git a/mojo/services/public/js/shell.js b/mojo/services/public/js/shell.js

index 338de5ee58a02c4a5a04cc2bd0ead20b87c40c51..8d90dcb2f579a61171cd1afb2bb61b9830010799 100644

--- a/mojo/services/public/js/shell.js

+++ b/mojo/services/public/js/shell.js

@@ -9,17 +9,12 @@ define("mojo/services/public/js/shell", [

"mojo/public/interfaces/application/shell.mojom",

"mojo/public/interfaces/application/service_provider.mojom",

"mojo/services/public/js/service_provider",

-], function(bindings,

- core,

- connection,

- shellMojom,

- serviceProviderMojom,

- serviceProvider) {

+], function(bindings, core, connection, shellMojom, spMojom, sp) {

const ProxyBindings = bindings.ProxyBindings;

const StubBindings = bindings.StubBindings;

- const ServiceProvider = serviceProvider.ServiceProvider;

- const ServiceProviderInterface = serviceProviderMojom.ServiceProvider;

+ const ServiceProvider = sp.ServiceProvider;

+ const ServiceProviderInterface = spMojom.ServiceProvider;

const ShellInterface = shellMojom.Shell;

class Shell {

« no previous file with comments | « mojo/services/public/js/service_provider.js ('k') | sky/tests/services/network.sky » ('j') | sky/tests/services/network.sky » ('J')