Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: net/quic/quic_sent_packet_manager_test.cc

Issue 837273004: Fixes typo, changing OnSpuriousPacketRetransmition to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Adds_alarm_FEC_Packet_83543120
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager_test.cc
diff --git a/net/quic/quic_sent_packet_manager_test.cc b/net/quic/quic_sent_packet_manager_test.cc
index 756c21a254d2ccddd8dadcb2bb112a9d1fce9b4a..e6ab280e2c6b962bd7fd508a5d98f0318b26d41a 100644
--- a/net/quic/quic_sent_packet_manager_test.cc
+++ b/net/quic/quic_sent_packet_manager_test.cc
@@ -37,7 +37,7 @@ MATCHER(KeyEq, "") {
class MockDebugDelegate : public QuicSentPacketManager::DebugDelegate {
public:
- MOCK_METHOD2(OnSpuriousPacketRetransmition,
+ MOCK_METHOD2(OnSpuriousPacketRetransmission,
void(TransmissionType transmission_type,
QuicByteCount byte_size));
};
@@ -416,8 +416,8 @@ TEST_F(QuicSentPacketManagerTest, RetransmitTwiceThenAckPreviousBeforeSend) {
TEST_F(QuicSentPacketManagerTest, RetransmitTwiceThenAckFirst) {
StrictMock<MockDebugDelegate> debug_delegate;
- EXPECT_CALL(debug_delegate, OnSpuriousPacketRetransmition(
- TLP_RETRANSMISSION, kDefaultLength)).Times(2);
+ EXPECT_CALL(debug_delegate, OnSpuriousPacketRetransmission(
+ TLP_RETRANSMISSION, kDefaultLength)).Times(2);
ramant (doing other things) 2015/01/14 02:13:07 nit: not 100% why this format is preferred.
Jana 2015/01/14 02:16:32 Maybe rch knows. I've mostly given up on trying to
ramant (doing other things) 2015/01/14 02:17:40 I meant to say, old format seems to be reasonable.
Jana 2015/01/14 02:22:53 Actually, this seems off, since there's a Times(2)
manager_.set_debug_delegate(&debug_delegate);
SendDataPacket(1);
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698