Fixes typo, changing OnSpuriousPacketRetransmition to

Fixes typo, changing OnSpuriousPacketRetransmition to
OnSpuriousPacketRetransmission.

Merge internal change: 83546153

Plus minor changes from "git cl format net".

R=jri@chromium.org, rch@chromium.org

[Jana, 2015-01-14 02:02:45]

lgtm

[ramant (doing other things), 2015-01-14 02:13:07]

https://codereview.chromium.org/837273004/diff/1/net/quic/quic_sent_packet_ma...
File net/quic/quic_sent_packet_manager_test.cc (right):

https://codereview.chromium.org/837273004/diff/1/net/quic/quic_sent_packet_ma...
net/quic/quic_sent_packet_manager_test.cc:420: TLP_RETRANSMISSION,
kDefaultLength)).Times(2);
nit: not 100% why this format is preferred.

[Jana, 2015-01-14 02:16:32]

https://codereview.chromium.org/837273004/diff/1/net/quic/quic_sent_packet_ma...
File net/quic/quic_sent_packet_manager_test.cc (right):

https://codereview.chromium.org/837273004/diff/1/net/quic/quic_sent_packet_ma...
net/quic/quic_sent_packet_manager_test.cc:420: TLP_RETRANSMISSION,
kDefaultLength)).Times(2);
On 2015/01/14 02:13:07, ramant wrote:
> nit: not 100% why this format is preferred.

Maybe rch knows. I've mostly given up on trying to understand why a particular
formatting is preferred :-)

[ramant (doing other things), 2015-01-14 02:17:41]

https://codereview.chromium.org/837273004/diff/1/net/quic/quic_sent_packet_ma...
File net/quic/quic_sent_packet_manager_test.cc (right):

https://codereview.chromium.org/837273004/diff/1/net/quic/quic_sent_packet_ma...
net/quic/quic_sent_packet_manager_test.cc:420: TLP_RETRANSMISSION,
kDefaultLength)).Times(2);
On 2015/01/14 02:13:07, ramant wrote:
> nit: not 100% why this format is preferred.

I meant to say, old format seems to be reasonable. But it looks like new format
says the arguments are for OnSpuriousPacketRetransmission and thus it is
indented 4 spaces from that function call.

[Jana, 2015-01-14 02:22:53]

https://codereview.chromium.org/837273004/diff/1/net/quic/quic_sent_packet_ma...
File net/quic/quic_sent_packet_manager_test.cc (right):

https://codereview.chromium.org/837273004/diff/1/net/quic/quic_sent_packet_ma...
net/quic/quic_sent_packet_manager_test.cc:420: TLP_RETRANSMISSION,
kDefaultLength)).Times(2);
On 2015/01/14 02:17:40, ramant wrote:
> On 2015/01/14 02:13:07, ramant wrote:
> > nit: not 100% why this format is preferred.
> 
> I meant to say, old format seems to be reasonable. But it looks like new
format
> says the arguments are for OnSpuriousPacketRetransmission and thus it is
> indented 4 spaces from that function call.

Actually, this seems off, since there's a Times(2) at the end of the statement.
If line 420 was only params to OnSpuriousPacketRetransmission, this reformatting
would make sense, but it there's the suffix to EXPECT_CALL at the tail. I think
I'd prefer it the way it was... unless we're strongly following git cl format
diktats.

[Ryan Hamilton, 2015-01-14 19:15:03]

lgtm