Reland "skia: Add 'skia_unittests' test suite for this directory."

Reland "skia: Add 'skia_unittests' test suite for this directory."

This should be a lightweight test suite that should allow a dev changing
something in skia/ext to test it much more quickly than having to build
all 'unit_tests' target just to run the tests from skia/ext.

It was reverted because it broke Mac GN with error like:
duplicate symbol __ZN3gfx27SkMatrixToCGAffineTransformERK8SkMatrix in:
    obj/skia/ext/skia_unittests.skia_utils_mac_unittest.o
        obj/skia/ext/skia.skia_utils_mac.o
        (and more similar issues).

BUG=444058
TEST=skia_unittests links and runs fine.
R=danakj@chromium.org,thakis@chromium.org,glider@chromium.org,sky@chromium.org
TBR=glider@chromium.org (already reviewed tools/valgrind - and no changes were made at that directory).

Committed: https://crrev.com/0f9c5eed19153d16a29a206356ff581e003f514a
Cr-Commit-Position: refs/heads/master@{#310688}

[tfarina, 2015-01-07 18:14:29]

PTAL.

Fix is in Patch set 2.

[Nico, 2015-01-07 18:16:59]

lgtm, but I'd almost change the broken include in a different cl

[danakj, 2015-01-07 18:21:07]

On Wed, Jan 7, 2015 at 10:16 AM, <thakis@chromium.org> wrote:

> lgtm, but I'd almost change the broken include in a different cl
>

+1 would be nice


>
> https://codereview.chromium.org/837243002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2015-01-07 18:25:02]

(if you do this, it looks like the skia/ext/skia_utils_ios_unittest.mm
makes the same mistake – maybe you can fix that file too while at it)

On Wed, Jan 7, 2015 at 10:20 AM, Dana Jansens <danakj@chromium.org> wrote:

> On Wed, Jan 7, 2015 at 10:16 AM, <thakis@chromium.org> wrote:
>
>> lgtm, but I'd almost change the broken include in a different cl
>>
>
> +1 would be nice
>
>
>>
>> https://codereview.chromium.org/837243002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2015-01-07 20:42:42]

LGTM

[tfarina, 2015-01-09 01:28:20]

Resubmitting this as the fix has been landed in
https://chromium.googlesource.com/chromium/src.git/+/786967e07357b26548fc1c21....

[tfarina, 2015-01-09 01:28:32]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-01-09 01:30:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/837243002/40001

[commit-bot: I haz the power, 2015-01-09 02:51:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-09 02:52:18]

Patchset 3 (id:??) landed as
https://crrev.com/0f9c5eed19153d16a29a206356ff581e003f514a
Cr-Commit-Position: refs/heads/master@{#310688}

[Alexander Potapenko, 2015-01-12 09:22:23]

On 2015/01/09 02:52:18, I haz the power (commit-bot) wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/0f9c5eed19153d16a29a206356ff581e003f514a
> Cr-Commit-Position: refs/heads/master@{#310688}

tools/valgrind lgtm