Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: content/browser/download/download_create_info.cc

Issue 8372073: Merge 8401001 r107836 into branch 912: Fix history importing by delaying DownloadManager creation. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/912/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_create_info.h ('k') | content/browser/download/download_file.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_create_info.cc
===================================================================
--- content/browser/download/download_create_info.cc (revision 108294)
+++ content/browser/download/download_create_info.cc (working copy)
@@ -15,7 +15,7 @@
int64 received_bytes,
int64 total_bytes,
int32 state,
- int32 download_id,
+ const DownloadId& download_id,
bool has_user_gesture,
content::PageTransition transition_type)
: path(path),
@@ -37,7 +37,7 @@
received_bytes(0),
total_bytes(0),
state(-1),
- download_id(-1),
+ download_id(DownloadId::Invalid()),
has_user_gesture(false),
transition_type(content::PAGE_TRANSITION_LINK),
db_handle(0),
@@ -49,7 +49,7 @@
std::string DownloadCreateInfo::DebugString() const {
return base::StringPrintf("{"
- " download_id = %d"
+ " download_id = %s"
" url = \"%s\""
" path = \"%" PRFilePath "\""
" received_bytes = %" PRId64
@@ -57,7 +57,7 @@
" request_handle = %s"
" prompt_user_for_save_location = %c"
" }",
- download_id,
+ download_id.DebugString().c_str(),
url().spec().c_str(),
path.value().c_str(),
received_bytes,
« no previous file with comments | « content/browser/download/download_create_info.h ('k') | content/browser/download/download_file.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698