content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 837183002: Add a helper function and update test results with ax role of table header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 837183002: Add a helper function and update test results with ax role of table header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update TC Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility_win.cc » ('j') | content/browser/accessibility/browser_accessibility_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index c7c569725f607ca99458319b4ee5bb68c743bfe4..ae4171f20571685ac30cc309511424026426a63b 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -233,7 +233,9 @@ NSDictionary* attributeToMethodNameMap = nil;

}

- (NSValue*)columnIndexRange {

- if ([self internalRole] != ui::AX_ROLE_CELL)

+ if ([self internalRole] != ui::AX_ROLE_CELL &&

dmazzoni 2015/01/08 18:11:25 Please add a helper function for this, like IsCell

je_julie(Not used) 2015/01/09 16:47:37 Done

+ [self internalRole] != ui::AX_ROLE_COLUMN_HEADER &&

+ [self internalRole] != ui::AX_ROLE_ROW_HEADER)

return nil;

int column = -1;

@@ -666,7 +668,9 @@ NSDictionary* attributeToMethodNameMap = nil;

}

- (NSValue*)rowIndexRange {

- if ([self internalRole] != ui::AX_ROLE_CELL)

+ if ([self internalRole] != ui::AX_ROLE_CELL &&

+ [self internalRole] != ui::AX_ROLE_COLUMN_HEADER &&

+ [self internalRole] != ui::AX_ROLE_ROW_HEADER)

return nil;

int row = -1;

@@ -1074,7 +1078,9 @@ NSDictionary* attributeToMethodNameMap = nil;

j < child->PlatformChildCount();

++j) {

BrowserAccessibility* cell = child->PlatformGetChild(j);

- if (cell->GetRole() != ui::AX_ROLE_CELL)

+ if ([self internalRole] != ui::AX_ROLE_CELL &&

+ [self internalRole] != ui::AX_ROLE_COLUMN_HEADER &&

+ [self internalRole] != ui::AX_ROLE_ROW_HEADER)

continue;

int colIndex;

if (!cell->GetIntAttribute(

« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility_win.cc » ('j') | content/browser/accessibility/browser_accessibility_win.cc » ('J')