Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Side by Side Diff: src/compiler/pipeline.cc

Issue 837173002: [turbofan] remove spill slot reuse flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/register-allocator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/pipeline.h" 5 #include "src/compiler/pipeline.h"
6 6
7 #include <fstream> // NOLINT(readability/streams) 7 #include <fstream> // NOLINT(readability/streams)
8 #include <sstream> 8 #include <sstream>
9 9
10 #include "src/base/platform/elapsed-timer.h" 10 #include "src/base/platform/elapsed-timer.h"
(...skipping 566 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 577
578 struct AllocateDoubleRegistersPhase { 578 struct AllocateDoubleRegistersPhase {
579 static const char* phase_name() { return "allocate double registers"; } 579 static const char* phase_name() { return "allocate double registers"; }
580 580
581 void Run(PipelineData* data, Zone* temp_zone) { 581 void Run(PipelineData* data, Zone* temp_zone) {
582 data->register_allocator()->AllocateDoubleRegisters(); 582 data->register_allocator()->AllocateDoubleRegisters();
583 } 583 }
584 }; 584 };
585 585
586 586
587 struct ReuseSpillSlotsPhase { 587 struct AssignSpillSlotsPhase {
588 static const char* phase_name() { return "reuse spill slots"; } 588 static const char* phase_name() { return "assign spill slots"; }
589 589
590 void Run(PipelineData* data, Zone* temp_zone) { 590 void Run(PipelineData* data, Zone* temp_zone) {
591 data->register_allocator()->ReuseSpillSlots(); 591 data->register_allocator()->AssignSpillSlots();
592 } 592 }
593 }; 593 };
594 594
595 595
596 struct CommitAssignmentPhase { 596 struct CommitAssignmentPhase {
597 static const char* phase_name() { return "commit assignment"; } 597 static const char* phase_name() { return "commit assignment"; }
598 598
599 void Run(PipelineData* data, Zone* temp_zone) { 599 void Run(PipelineData* data, Zone* temp_zone) {
600 data->register_allocator()->CommitAssignment(); 600 data->register_allocator()->CommitAssignment();
601 } 601 }
(...skipping 427 matching lines...) Expand 10 before | Expand all | Expand 10 after
1029 OFStream os(stdout); 1029 OFStream os(stdout);
1030 PrintableInstructionSequence printable = {config, data->sequence()}; 1030 PrintableInstructionSequence printable = {config, data->sequence()};
1031 os << "----- Instruction sequence before register allocation -----\n" 1031 os << "----- Instruction sequence before register allocation -----\n"
1032 << printable; 1032 << printable;
1033 } 1033 }
1034 if (verifier != nullptr) { 1034 if (verifier != nullptr) {
1035 CHECK(!data->register_allocator()->ExistsUseWithoutDefinition()); 1035 CHECK(!data->register_allocator()->ExistsUseWithoutDefinition());
1036 } 1036 }
1037 Run<AllocateGeneralRegistersPhase>(); 1037 Run<AllocateGeneralRegistersPhase>();
1038 Run<AllocateDoubleRegistersPhase>(); 1038 Run<AllocateDoubleRegistersPhase>();
1039 if (FLAG_turbo_reuse_spill_slots) { 1039 Run<AssignSpillSlotsPhase>();
1040 Run<ReuseSpillSlotsPhase>(); 1040
1041 }
1042 Run<CommitAssignmentPhase>(); 1041 Run<CommitAssignmentPhase>();
1043 Run<PopulatePointerMapsPhase>(); 1042 Run<PopulatePointerMapsPhase>();
1044 Run<ConnectRangesPhase>(); 1043 Run<ConnectRangesPhase>();
1045 Run<ResolveControlFlowPhase>(); 1044 Run<ResolveControlFlowPhase>();
1046 if (FLAG_turbo_move_optimization) { 1045 if (FLAG_turbo_move_optimization) {
1047 Run<OptimizeMovesPhase>(); 1046 Run<OptimizeMovesPhase>();
1048 } 1047 }
1049 1048
1050 if (FLAG_trace_turbo_graph) { 1049 if (FLAG_trace_turbo_graph) {
1051 OFStream os(stdout); 1050 OFStream os(stdout);
(...skipping 19 matching lines...) Expand all
1071 } 1070 }
1072 1071
1073 1072
1074 void Pipeline::TearDown() { 1073 void Pipeline::TearDown() {
1075 InstructionOperand::TearDownCaches(); 1074 InstructionOperand::TearDownCaches();
1076 } 1075 }
1077 1076
1078 } // namespace compiler 1077 } // namespace compiler
1079 } // namespace internal 1078 } // namespace internal
1080 } // namespace v8 1079 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/register-allocator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698