Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 837173002: [turbofan] remove spill slot reuse flag (Closed)

Created:
5 years, 11 months ago by dcarney
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] remove spill slot reuse flag BUG= Committed: https://crrev.com/4de38bfe385f7d98f9bed5e1939a7f511439e800 Cr-Commit-Position: refs/heads/master@{#25970}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -71 lines) Patch
M src/compiler/pipeline.cc View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M src/compiler/register-allocator.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 8 chunks +7 lines, -59 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
LGTM with nit https://codereview.chromium.org/837173002/diff/20001/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/837173002/diff/20001/src/compiler/pipeline.cc#newcode588 src/compiler/pipeline.cc:588: static const char* phase_name() { return ...
5 years, 11 months ago (2015-01-07 12:13:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837173002/40001
5 years, 11 months ago (2015-01-07 12:14:57 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-07 12:46:07 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 12:46:25 UTC) #6
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4de38bfe385f7d98f9bed5e1939a7f511439e800
Cr-Commit-Position: refs/heads/master@{#25970}

Powered by Google App Engine
This is Rietveld 408576698