Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 837153002: Restrict representation inference to avoid truncation of phi inputs. (Closed)

Created:
5 years, 11 months ago by Jarin
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
titzer, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Restrict representation inference to avoid truncation of phi inputs. BUG=chromium:446778 LOG=N Committed: https://crrev.com/80a7be5cd97d10b823a2bc24358a302ed541bc26 Cr-Commit-Position: refs/heads/master@{#25967}

Patch Set 1 #

Patch Set 2 : Comment tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M src/compiler/simplified-lowering.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +2 lines, -6 lines 0 comments Download
A test/mjsunit/compiler/regress-446778.js View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please?
5 years, 11 months ago (2015-01-07 10:10:58 UTC) #2
Benedikt Meurer
lgtm
5 years, 11 months ago (2015-01-07 11:12:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837153002/20001
5 years, 11 months ago (2015-01-07 11:12:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-07 11:38:50 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 11:39:04 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80a7be5cd97d10b823a2bc24358a302ed541bc26
Cr-Commit-Position: refs/heads/master@{#25967}

Powered by Google App Engine
This is Rietveld 408576698