Add DumpAccessibilityTree tests (12 of 20)

Add DumpAccessibilityTree tests (12 of 20)

BUG=170584
Committed: https://crrev.com/1152dfcbf4ffff724a892b4877d1c1ba25cf2594
Cr-Commit-Position: refs/heads/master@{#312085}

[shreeramk, 2015-01-08 05:20:20]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[shreeramk, 2015-01-08 05:20:20]

Please review.

Not sure about the reason why content_browsertests are failing for mac and
windows. Both are already having correct expecations.

Thanks!

[dmazzoni, 2015-01-08 19:13:36]

lgtm

https://codereview.chromium.org/837123004/diff/20001/content/test/data/access...
File content/test/data/accessibility/aria/aria-controls-expected-win.txt
(right):

https://codereview.chromium.org/837123004/diff/20001/content/test/data/access...
content/test/data/accessibility/aria/aria-controls-expected-win.txt:1: #<skip -
Not Implemented>
Would you like to implement this (in a follow-up changelist)?

The implementation would be very similar to aria-labelledby - see the line of
code relation->Initialize(this, IA2_RELATION_LABELLED_BY); in
browser_accessibility_win.cc

https://codereview.chromium.org/837123004/diff/20001/content/test/data/access...
File content/test/data/accessibility/aria/aria-link-expected-android.txt
(right):

https://codereview.chromium.org/837123004/diff/20001/content/test/data/access...
content/test/data/accessibility/aria/aria-link-expected-android.txt:2:
android.view.View
This looks like an accidental oversight that we're not dumping whether or not
something is a link in the Android output.

Please add this line to accessibility_tree_formatter_android.cc, in
AccessibilityTreeFormatter::AddProperties:

dict->SetBoolean("link", android_node->IsLink());

Then the expectation will indicate that this is a link.

https://codereview.chromium.org/837123004/diff/20001/content/test/data/access...
File content/test/data/accessibility/html/code-expected-mac.txt (right):

https://codereview.chromium.org/837123004/diff/20001/content/test/data/access...
content/test/data/accessibility/html/code-expected-mac.txt:4: AXUnknown
I think this is from the <br> - maybe take that out of the html to not confuse
things?

[shreeramk, 2015-01-09 05:03:54]

>
https://codereview.chromium.org/837123004/diff/20001/content/test/data/access...
> content/test/data/accessibility/aria/aria-controls-expected-win.txt:1: #<skip
-
> Not Implemented>
> Would you like to implement this (in a follow-up changelist)?

Sure I ll implement if a follow up CL.
  
>
https://codereview.chromium.org/837123004/diff/20001/content/test/data/access...
> content/test/data/accessibility/aria/aria-link-expected-android.txt:2:
> android.view.View
> This looks like an accidental oversight that we're not dumping whether or not
> something is a link in the Android output.
> 

Added.

>
https://codereview.chromium.org/837123004/diff/20001/content/test/data/access...
> content/test/data/accessibility/html/code-expected-mac.txt:4: AXUnknown
> I think this is from the <br> - maybe take that out of the html to not confuse
> things?

Modified.

[shreeramk, 2015-01-09 11:00:48]

https://codereview.chromium.org/837123004/diff/80001/content/browser/accessib...
File content/browser/accessibility/accessibility_tree_formatter_android.cc
(right):

https://codereview.chromium.org/837123004/diff/80001/content/browser/accessib...
content/browser/accessibility/accessibility_tree_formatter_android.cc:94:
dict->SetBoolean("link", android_node->IsLink());
not sure why after adding this, link is not exposed. I ll debug and fix
this.

[shreeramk, 2015-01-12 05:29:37]

@Dominic: PTAL. Thanks!

https://codereview.chromium.org/837123004/diff/80001/content/browser/accessib...
File content/browser/accessibility/accessibility_tree_formatter_android.cc
(right):

https://codereview.chromium.org/837123004/diff/80001/content/browser/accessib...
content/browser/accessibility/accessibility_tree_formatter_android.cc:94:
dict->SetBoolean("link", android_node->IsLink());
On 2015/01/09 11:00:48, shreeramk wrote:
> not sure why after adding this, link is not exposed. I ll debug and fix
> this.

Reason:
I found out the reason why it is not getting exposed.

We are not setting node.setLink in setAccessibilityNodeInfoBooleanAttributes in
BrowserAccessibilityManager.java.

We can't set also because there is not setLink() API in
AccessibilityNodeInfo(http://developer.android.com/reference/android/view/accessibility/AccessibilityNodeInfo.html)

[dmazzoni, 2015-01-12 07:41:35]

On 2015/01/12 05:29:37, shreeramk wrote:
> @Dominic: PTAL. Thanks!
> 
>
https://codereview.chromium.org/837123004/diff/80001/content/browser/accessib...
> File content/browser/accessibility/accessibility_tree_formatter_android.cc
> (right):
> 
>
https://codereview.chromium.org/837123004/diff/80001/content/browser/accessib...
> content/browser/accessibility/accessibility_tree_formatter_android.cc:94:
> dict->SetBoolean("link", android_node->IsLink());
> On 2015/01/09 11:00:48, shreeramk wrote:
> > not sure why after adding this, link is not exposed. I ll debug and fix
> > this.
> 
> Reason:
> I found out the reason why it is not getting exposed.
> 
> We are not setting node.setLink in setAccessibilityNodeInfoBooleanAttributes
in
> BrowserAccessibilityManager.java.
> 
> We can't set also because there is not setLink() API in
>
AccessibilityNodeInfo(http://developer.android.com/reference/android/view/accessibility/AccessibilityNodeInfo.html)

BrowserAccessibilityManager.java does annotate a view as a link in
setAccessibilityNodeInfoContentDescription. It seems a little odd but that's the
correct way to mark something as a link.

For DumpAccessibilityTree tests, we should just dump the string "link" to
indicate whether we did that or not.

[shreeramk, 2015-01-12 10:57:24]

On 2015/01/12 07:41:35, dmazzoni wrote:
> On 2015/01/12 05:29:37, shreeramk wrote:
> > @Dominic: PTAL. Thanks!
> > 
> >
>
https://codereview.chromium.org/837123004/diff/80001/content/browser/accessib...
> > File content/browser/accessibility/accessibility_tree_formatter_android.cc
> > (right):
> > 
> >
>
https://codereview.chromium.org/837123004/diff/80001/content/browser/accessib...
> > content/browser/accessibility/accessibility_tree_formatter_android.cc:94:
> > dict->SetBoolean("link", android_node->IsLink());
> > On 2015/01/09 11:00:48, shreeramk wrote:
> > > not sure why after adding this, link is not exposed. I ll debug and fix
> > > this.
> > 
> > Reason:
> > I found out the reason why it is not getting exposed.
> > 
> > We are not setting node.setLink in setAccessibilityNodeInfoBooleanAttributes
> in
> > BrowserAccessibilityManager.java.
> > 
> > We can't set also because there is not setLink() API in
> >
>
AccessibilityNodeInfo(http://developer.android.com/reference/android/view/accessibility/AccessibilityNodeInfo.html)
> 
> BrowserAccessibilityManager.java does annotate a view as a link in
> setAccessibilityNodeInfoContentDescription. It seems a little odd but that's
the
> correct way to mark something as a link.
> 
> For DumpAccessibilityTree tests, we should just dump the string "link" to
> indicate whether we did that or not.

Yeah, that code is also there, still its not exposing.

[shreeramk, 2015-01-19 08:56:20]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2015-01-19 08:57:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/837123004/120001

[shreeramk, 2015-01-19 08:58:40]

https://codereview.chromium.org/837123004/diff/120001/content/browser/accessi...
File content/browser/accessibility/accessibility_tree_formatter_android.cc
(right):

https://codereview.chromium.org/837123004/diff/120001/content/browser/accessi...
content/browser/accessibility/accessibility_tree_formatter_android.cc:39:
"link",
It was not working because it was not listed here in the list of boolean
attributes.

[commit-bot: I haz the power, 2015-01-19 09:18:50]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-01-19 09:19:46]

Patchset 7 (id:??) landed as
https://crrev.com/1152dfcbf4ffff724a892b4877d1c1ba25cf2594
Cr-Commit-Position: refs/heads/master@{#312085}