Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: Source/WebCore/inspector/front-end/ScriptsSearchScope.js

Issue 8371003: Merge 97851 - Web Inspector: Enable caseSensitive search / Regex support in advanced search. (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/912/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/inspector/front-end/Script.js ('k') | Source/WebCore/inspector/front-end/SourceFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/inspector/front-end/ScriptsSearchScope.js
===================================================================
--- Source/WebCore/inspector/front-end/ScriptsSearchScope.js (revision 98111)
+++ Source/WebCore/inspector/front-end/ScriptsSearchScope.js (working copy)
@@ -55,7 +55,7 @@
function searchCallbackWrapper(uiSourceCode, searchMatches)
{
if (searchMatches.length) {
- var searchResult = {file: uiSourceCode, searchMatches: searchMatches};
+ var searchResult = new WebInspector.FileBasedSearchResultsPane.SearchResult(uiSourceCode, searchMatches);
searchResultCallback(searchResult);
}
--callbacksLeft;
@@ -72,7 +72,7 @@
// Increase callbacksLeft first because searchInContent call could be synchronous.
callbacksLeft++;
// FIXME: We should not request next searchInContent unless previous one is already finished.
- uiSourceCode.searchInContent(searchConfig.query, searchCallbackWrapper.bind(this, uiSourceCode));
+ uiSourceCode.searchInContent(searchConfig.query, !searchConfig.ignoreCase, searchConfig.isRegex, searchCallbackWrapper.bind(this, uiSourceCode));
}
}
maybeSearchFinished();
« no previous file with comments | « Source/WebCore/inspector/front-end/Script.js ('k') | Source/WebCore/inspector/front-end/SourceFrame.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698