Disable type propagation for class/top-level fields.

pkg/analyzer/lib/src/generated/resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.resolver;
 
 import "dart:math" as math;
 import 'dart:collection';
 
 import 'package:analyzer/src/generated/utilities_collection.dart';
@@ skipping 11415 matching lines @@
     // It also covers an important case that is not applicable in the spec:
     // for union types, we want an is-check to promote from an union type to
     // (a subtype of) any of its members.
     //
     // The first check, that [! (C << P)], covers the case where [P] and [C] are
     // unrelated types; This case is not addressed in the spec for static types.
     if (currentType == null ||
         allowPrecisionLoss ||
         !currentType.isMoreSpecificThan(potentialType) ||
         potentialType.isMoreSpecificThan(currentType)) {
-      if (element is PropertyInducingElement) {
-        PropertyInducingElement variable = element;
-        if (!variable.isConst && !variable.isFinal) {
-          return;
-        }
-        (variable as PropertyInducingElementImpl).propagatedType =
-            potentialType;
-      }
+      // TODO(scheglov) type propagation for instance/top-level fields
+      // was disabled because it depends on the order or visiting.
+      // If both field and its client are in the same unit, and we visit
+      // the client before the field, then propagated type is not set yet.
+//      if (element is PropertyInducingElement) {
+//        PropertyInducingElement variable = element;
+//        if (!variable.isConst && !variable.isFinal) {
+//          return;
+//        }
+//        (variable as PropertyInducingElementImpl).propagatedType =
+//            potentialType;
+//      }
       _overrideManager.setType(element, potentialType);
     }
   }
 
   @override
   Object visitAnnotation(Annotation node) {
     AstNode parent = node.parent;
     if (identical(parent, _enclosingClassDeclaration) ||
         identical(parent, _enclosingFunctionTypeAlias)) {
       return null;
@@ skipping 4951 matching lines @@
    * library.
    */
   final HashSet<String> members = new HashSet<String>();
 
   /**
    * Names of resolved or unresolved class members that are read in the
    * library.
    */
   final HashSet<String> readMembers = new HashSet<String>();
 }