Fold bench source file list into bench.gyp.

Fold bench source file list into bench.gyp.

It is one less file and doesn't make things much worse.

BUG=None
TEST=./gyp_skia
R=mtklein@google.com

Committed: http://code.google.com/p/skia/source/detail?r=12412

[tfarina, 2013-11-25 01:20:26]

Mike, do you mind this cleanup?

Please, take a look.

Thanks,

[mtklein, 2013-11-25 13:17:36]

Seems fine to me.  Just one little tweak request while we're at it.

https://codereview.chromium.org/83703004/diff/1/gyp/bench.gyp
File gyp/bench.gyp (right):

https://codereview.chromium.org/83703004/diff/1/gyp/bench.gyp#newcode82
gyp/bench.gyp:82: '../bench/SkBenchmark.cpp',
Can you put these two SkBenchmark files down with SkBenchLogger too?  I'd like
to take the opportunity to visually distinguish the benchmarks themselves from
the bench framework.

https://codereview.chromium.org/83703004/diff/1/gyp/bench.gyp#newcode94
gyp/bench.gyp:94: '../bench/benchmain.cpp',
And this one?

[tfarina, 2013-11-26 15:41:08]

https://codereview.chromium.org/83703004/diff/1/gyp/bench.gyp
File gyp/bench.gyp (right):

https://codereview.chromium.org/83703004/diff/1/gyp/bench.gyp#newcode82
gyp/bench.gyp:82: '../bench/SkBenchmark.cpp',
On 2013/11/25 13:17:37, mtklein wrote:
> Can you put these two SkBenchmark files down with SkBenchLogger too?  I'd like
> to take the opportunity to visually distinguish the benchmarks themselves from
> the bench framework.

Do you mind if we split this in two targets? Say, bench_lib (or a better name
you have) for the framework and bench (or bench_exe) for the executable?

https://codereview.chromium.org/83703004/diff/1/gyp/bench.gyp#newcode94
gyp/bench.gyp:94: '../bench/benchmain.cpp',
On 2013/11/25 13:17:37, mtklein wrote:
> And this one?
See question above. We may just put this in a separate target.

[mtklein, 2013-11-26 15:45:18]

https://codereview.chromium.org/83703004/diff/1/gyp/bench.gyp
File gyp/bench.gyp (right):

https://codereview.chromium.org/83703004/diff/1/gyp/bench.gyp#newcode82
gyp/bench.gyp:82: '../bench/SkBenchmark.cpp',
Let's wait to do this until something wants to depend on bench_lib without
bench_exe or vice versa.

On 2013/11/26 15:41:08, tfarina wrote:
> On 2013/11/25 13:17:37, mtklein wrote:
> > Can you put these two SkBenchmark files down with SkBenchLogger too?  I'd
like
> > to take the opportunity to visually distinguish the benchmarks themselves
from
> > the bench framework.
> 
> Do you mind if we split this in two targets? Say, bench_lib (or a better name
> you have) for the framework and bench (or bench_exe) for the executable?

[tfarina, 2013-11-26 22:28:59]

Done.

[mtklein, 2013-11-26 23:23:12]

lgtm

[commit-bot: I haz the power, 2013-11-26 23:59:07]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/83703004/40001

[commit-bot: I haz the power, 2013-11-27 00:44:05]

Change committed as 12412