Issue 83703002: [cr tool] Changing exit to raise for not overridden test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83703002: [cr tool] Changing exit to raise for not overridden test. (Closed)

Created:
7 years, 1 month ago by ian_cottrell

Modified:
7 years, 1 month ago

Reviewers:
Miguel Garcia, Andrew Hayden (chromium.org), bulach

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Changing exit to raise for not overridden test, to match the change made in 83043003 BUG=316397 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236826

Patch Set 2 : Quote change #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	tools/cr/cr/commands/command.py	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm w/ nit: https://codereview.chromium.org/83703002/diff/1/tools/cr/cr/commands/command.py File tools/cr/cr/commands/command.py (right): https://codereview.chromium.org/83703002/diff/1/tools/cr/cr/commands/command.py#newcode103 tools/cr/cr/commands/command.py:103: raise NotImplementedError("Must be overridden.") nit: ' ...

7 years, 1 month ago (2013-11-22 16:12:33 UTC) #2

ian_cottrell

On 2013/11/22 16:12:33, bulach wrote: > lgtm w/ nit: > > https://codereview.chromium.org/83703002/diff/1/tools/cr/cr/commands/command.py > File tools/cr/cr/commands/command.py ...

7 years, 1 month ago (2013-11-22 18:57:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iancottrell@chromium.org/83703002/60001

7 years, 1 month ago (2013-11-22 18:58:33 UTC) #4

Message was sent while issue was closed.

Change committed as 236826

Expand Messages | Collapse Messages

Issue 83703002: [cr tool] Changing exit to raise for not overridden test. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Quote change #

Messages