Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 837023002: fixes for conics (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
Reviewers:
egdaniel, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fixes for conics - use std tolerance in edgebuilder, since the path has not been scaled-up to its super-sample size (that happens in the builder methods. - off-by-1 fix for pathops when using the output of the conicquadder BUG=skia: Committed: https://skia.googlesource.com/skia/+/3f4e045b4f8b97d189162d17c85b8410e083a3af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/core/SkEdgeBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpEdgeBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837023002/1
5 years, 11 months ago (2015-01-06 15:35:46 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-06 15:35:46 UTC) #4
reed1
5 years, 11 months ago (2015-01-06 15:37:39 UTC) #6
egdaniel
lgtm
5 years, 11 months ago (2015-01-06 15:39:19 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 15:44:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3f4e045b4f8b97d189162d17c85b8410e083a3af

Powered by Google App Engine
This is Rietveld 408576698