Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/browser/safe_browsing/database_manager.h

Issue 836963003: Add the result of the inclusion whitelist to the OffDomainInclusionDetector's analysis. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@#c1_sbDB_ODIsupport
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/database_manager.h
diff --git a/chrome/browser/safe_browsing/database_manager.h b/chrome/browser/safe_browsing/database_manager.h
index e93a65e6bc127f915c4498c9fed216f682be0a96..ae25839ee8a70b1df286c39477c4eb3c2945e828 100644
--- a/chrome/browser/safe_browsing/database_manager.h
+++ b/chrome/browser/safe_browsing/database_manager.h
@@ -172,6 +172,12 @@ class SafeBrowsingDatabaseManager
// This method is expected to be called on the IO thread.
virtual bool MatchDownloadWhitelistString(const std::string& str);
+ // Check if the |url| matches any of the full-length hashes from the off-
+ // domain inclusion whitelist. Returns true if there was a match and false
+ // otherwise. To make sure we are conservative, we will return true if an
+ // error occurs. This method is expected to be called on the IO thread.
grt (UTC plus 2) 2015/01/07 14:35:48 "expected to be called"? what if the unexpected ha
gab 2015/01/07 17:52:00 Done.
+ virtual bool MatchInclusionWhitelistUrl(const GURL& url);
+
// Check if the CSD malware IP matching kill switch is turned on.
virtual bool IsMalwareKillSwitchOn();

Powered by Google App Engine
This is Rietveld 408576698