tools/metrics/histograms/histograms.xml - Issue 836963003: Add the result of the inclusion whitelist to the OffDomainInclusionDetector's analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 836963003: Add the result of the inclusion whitelist to the OffDomainInclusionDetector's analysis. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@#c1_sbDB_ODIsupport

Patch Set: fix test leak Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 264e44fc14a4ba2dda7c1439b4aefdc52d87ad64..54faabbebeedab45d34409f1e02c263ffff650e9 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -31357,6 +31357,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

+ <obsolete>

+ Deprecated 01/2015.

+ </obsolete>

<owner>gab@chromium.org</owner>

Logs the resource type of each resource request for which an off-domain

@@ -31391,6 +31394,24 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="SBOffDomainInclusion.Suspicious" enum="ContentResourceType">

+ <owner>gab@chromium.org</owner>

+ <summary>

+ Logs the resource type of each resource request for which an off-domain

+ inclusion was detected by the OffDomainInclusionDetector and considered

+ suspicious.

+ </summary>

+</histogram>

+<histogram name="SBOffDomainInclusion.Whitelisted" enum="ContentResourceType">

+ <owner>gab@chromium.org</owner>

+ <summary>

+ Logs the resource type of each resource request for which an off-domain

+ inclusion was detected by the OffDomainInclusionDetector and ignored because

+ it was present on the inclusion whitelist.

+ </summary>

+</histogram>

<owner>rdsmith@chromium.org</owner>