Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 836923005: Add a performance benchmark for Node.baseURI (Closed)

Created:
5 years, 11 months ago by haraken
Modified:
5 years, 11 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a performance benchmark for Node.baseURI This benchmark is going to be used to evaluate performance of DOM attributes on prototype chains. To evalate the performance, you need to either: - Apply https://codereview.chromium.org/447523003/; or - Add [ExposeJSAccessors] on Node.baseURI. BUG=43394 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A PerformanceTests/Bindings/dom-attribute-on-prototoype.html View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
haraken
PTAL
5 years, 11 months ago (2015-01-13 11:38:16 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-13 11:38:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836923005/1
5 years, 11 months ago (2015-01-13 11:57:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/40583)
5 years, 11 months ago (2015-01-13 14:21:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836923005/1
5 years, 11 months ago (2015-01-13 14:26:14 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 15:45:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188298

Powered by Google App Engine
This is Rietveld 408576698