Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 836913003: Add check for read/write access to ChromeBrowserProvider. (Closed)

Created:
5 years, 11 months ago by Maria
Modified:
5 years, 11 months ago
Reviewers:
Ted C, michaelbai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add check for read/write access to ChromeBrowserProvider. This is used downstream for a more specific permissions check. BUG=434128 Committed: https://crrev.com/bd55958bd47d9c30e790e64361bf7a28940f4727 Cr-Commit-Position: refs/heads/master@{#310151}

Patch Set 1 #

Patch Set 2 : Fixed bug # #

Total comments: 4

Patch Set 3 : Added comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java View 1 2 5 chunks +22 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Maria
5 years, 11 months ago (2015-01-06 02:29:09 UTC) #2
michaelbai
On 2015/01/06 02:29:09, Maria wrote: Is the bug # 34128 correct?
5 years, 11 months ago (2015-01-06 03:41:52 UTC) #3
michaelbai
On 2015/01/06 02:29:09, Maria wrote: Is the bug # 34128 correct?
5 years, 11 months ago (2015-01-06 03:41:52 UTC) #4
Maria
On 2015/01/06 03:41:52, michaelbai wrote: > On 2015/01/06 02:29:09, Maria wrote: > > Is the ...
5 years, 11 months ago (2015-01-06 18:35:01 UTC) #5
michaelbai
lgtm https://codereview.chromium.org/836913003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java (right): https://codereview.chromium.org/836913003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java#newcode754 chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java:754: return true; Please add comment about why it ...
5 years, 11 months ago (2015-01-06 18:45:01 UTC) #6
Ted C
lgtm
5 years, 11 months ago (2015-01-06 18:57:48 UTC) #7
Maria
https://codereview.chromium.org/836913003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java (right): https://codereview.chromium.org/836913003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java#newcode754 chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java:754: return true; On 2015/01/06 18:45:01, michaelbai wrote: > Please ...
5 years, 11 months ago (2015-01-06 20:59:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836913003/40001
5 years, 11 months ago (2015-01-06 20:59:58 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-06 21:54:10 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 21:55:12 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/bd55958bd47d9c30e790e64361bf7a28940f4727
Cr-Commit-Position: refs/heads/master@{#310151}

Powered by Google App Engine
This is Rietveld 408576698