Issue 836893003: Replace sheet change methods with styleResolverChanged.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 836893003: Replace sheet change methods with styleResolverChanged. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Replace sheet change methods with styleResolverChanged. Unlike blink in sky we just want to mark tree scopes dirty. We can remove these methods, the dirty tree scope tracking we'll add in the future will take care of this. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9f2d739e5a919672d1f02922245315263582894d

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -25 lines)			Patch
M	sky/engine/core/css/CSSStyleSheet.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/dom/Document.h	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	sky/engine/core/dom/Document.cpp	View	1	1 chunk	+0 lines, -16 lines	0 comments	Download
M	sky/engine/core/html/HTMLStyleElement.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

esprehn

5 years, 11 months ago (2015-01-13 02:23:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
9f2d739e5a919672d1f02922245315263582894d (presubmit successful).