Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 836863002: Add tab support to RenderBlockLineLayout::stripTrailingSpace (Closed)

Created:
5 years, 11 months ago by eae
Modified:
5 years, 11 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add tab support to RenderBlockLineLayout::stripTrailingSpace Change RenderBlockLineLayout::stripTrailingSpace to measure the width of the first trailing white-space character instead of always assuming it's a space character. This fixes a bug where we wrap text unnecessarily for elements with a trailing tab character as we correctly measure the right character (tab) when computing the preferred with but subtract the width of a space character in stripTrailingSpace. R=pdr@chromium.org BUG=444544 TEST=fast/text/trailing_whitespace_wrapping.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -8 lines) Patch
A LayoutTests/fast/text/trailing_whitespace_wrapping.html View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/trailing_whitespace_wrapping-expected.html View 1 chunk +32 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +19 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eae
5 years, 11 months ago (2015-01-06 00:14:43 UTC) #2
pdr.
LGTM. Discussed this offline a bit. Lots of room for improvement in this code (collapsing ...
5 years, 11 months ago (2015-01-06 00:24:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836863002/1
5 years, 11 months ago (2015-01-06 00:25:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=187878
5 years, 11 months ago (2015-01-06 01:19:50 UTC) #6
falken
5 years, 11 months ago (2015-01-06 06:52:08 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/836103002/ by falken@chromium.org.

The reason for reverting is: trailing_whitespace_wrapping.html is crashing on
Mac10.6 (dbg)

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas...

Example:
22:23:47.008 3912 worker/4 fast/text/trailing_whitespace_wrapping.html crashed,
(stderr lines):
22:23:47.008 3912   Assertion failed: (bool (status_and &
kCTRunStatusRightToLeft) == backward), function _hb_coretext_shape, file
../../third_party/harfbuzz-ng/src/hb-coretext.cc, line 989.
22:23:47.009 3881 [30380/38782] fast/text/trailing_whitespace_wrapping.html
failed unexpectedly (renderer crashed [pid=6953]).

Powered by Google App Engine
This is Rietveld 408576698