Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 836843003: Removing the flags "auth-schemes", "auth-server-whitelist" and "auth-negotiate-delegate-whitelist" (Closed)

Created:
5 years, 11 months ago by MRV
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang, cbentzel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing the flags "auth-schemes", "auth-server-whitelist" and "auth-negotiate-delegate-whitelist" BUG=374951 Committed: https://crrev.com/819c4ccd94f77636503f7058fcc423fa0ba32fcf Cr-Commit-Position: refs/heads/master@{#310835}

Patch Set 1 #

Patch Set 2 : Integrated patches to one #

Patch Set 3 : incorporated changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M chrome/browser/prefs/command_line_pref_store.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
MRV
PTAL
5 years, 11 months ago (2015-01-06 07:36:27 UTC) #2
Lei Zhang
Deferring to cbentzel, happy to stamp with his approval.
5 years, 11 months ago (2015-01-06 20:18:27 UTC) #4
MRV
On 2015/01/06 20:18:27, Lei Zhang wrote: > Deferring to cbentzel, happy to stamp with his ...
5 years, 11 months ago (2015-01-07 03:50:09 UTC) #5
cbentzel
On 2015/01/07 03:50:09, MRV wrote: > On 2015/01/06 20:18:27, Lei Zhang wrote: > > Deferring ...
5 years, 11 months ago (2015-01-08 16:01:28 UTC) #6
cbentzel
On 2015/01/07 03:50:09, MRV wrote: > On 2015/01/06 20:18:27, Lei Zhang wrote: > > Deferring ...
5 years, 11 months ago (2015-01-08 16:01:29 UTC) #7
MRV
On 2015/01/08 16:01:29, cbentzel wrote: > On 2015/01/07 03:50:09, MRV wrote: > > On 2015/01/06 ...
5 years, 11 months ago (2015-01-09 06:15:06 UTC) #8
cbentzel
LGTM
5 years, 11 months ago (2015-01-09 10:17:40 UTC) #9
MRV
On 2015/01/09 10:17:40, cbentzel wrote: > LGTM Thanks cbentzel for reviewing the patch. @Lei zhang, ...
5 years, 11 months ago (2015-01-09 10:50:18 UTC) #10
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-09 19:06:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836843003/40001
5 years, 11 months ago (2015-01-09 19:08:09 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-09 20:04:28 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/819c4ccd94f77636503f7058fcc423fa0ba32fcf Cr-Commit-Position: refs/heads/master@{#310835}
5 years, 11 months ago (2015-01-09 20:05:33 UTC) #15
MRV
5 years, 11 months ago (2015-01-10 03:19:21 UTC) #16
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698