Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 836833002: Docs: Remove Send Feedback button (Closed)

Created:
5 years, 11 months ago by paulirish
Modified:
5 years, 11 months ago
Reviewers:
mkearney1, paulirish1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Docs: Remove Send Feedback button "Report a bug" -> "Report a content bug" Cleanup of old CSS BUG= Committed: https://crrev.com/79582464b500f76ee3a11b364160531442b90576 Cr-Commit-Position: refs/heads/master@{#310195}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M chrome/common/extensions/docs/static/css/out/site.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/static/sass/_article.scss View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/cc.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/private/site.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
paulirish
5 years, 11 months ago (2015-01-05 23:26:41 UTC) #2
paulirish
staged: https://chrome-apps-doc.appspot.com/_patch/836833002/devtools/index
5 years, 11 months ago (2015-01-06 00:13:53 UTC) #3
mkearney1
https://codereview.chromium.org/836833002/diff/1/chrome/common/extensions/docs/templates/private/site.html File chrome/common/extensions/docs/templates/private/site.html (right): https://codereview.chromium.org/836833002/diff/1/chrome/common/extensions/docs/templates/private/site.html#newcode63 chrome/common/extensions/docs/templates/private/site.html:63: <a href="https://www.google.com/">Google</a><a href="https://developers.google.com/site-terms">Terms of Service</a><a href="http://www.google.com/intl/en/privacy/">Privacy Policy</a><a href="" data-feedback>Report ...
5 years, 11 months ago (2015-01-06 00:15:05 UTC) #4
paulirish
> Notice there's no link here! There never was, but we need to add one, ...
5 years, 11 months ago (2015-01-06 19:52:11 UTC) #5
mkearney1
lgtm
5 years, 11 months ago (2015-01-06 20:10:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836833002/20001
5 years, 11 months ago (2015-01-06 20:12:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/33448)
5 years, 11 months ago (2015-01-06 20:48:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836833002/20001
5 years, 11 months ago (2015-01-07 00:37:24 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-07 00:58:14 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 00:59:22 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/79582464b500f76ee3a11b364160531442b90576
Cr-Commit-Position: refs/heads/master@{#310195}

Powered by Google App Engine
This is Rietveld 408576698