Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 836783004: media: Handle promise resolve/rejection in CdmPromiseAdapter. (Closed)

Created:
5 years, 11 months ago by xhwang
Modified:
5 years, 11 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Handle promise resolve/rejection in CdmPromiseAdapter. BUG=442584 TEST=No functionality change. Committed: https://crrev.com/4f353712e360da935c67885a26befddafedb2f86 Cr-Commit-Position: refs/heads/master@{#311180}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix win/mac by MEDIA_EXPORT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -43 lines) Patch
M content/renderer/pepper/content_decryptor_delegate.cc View 4 chunks +6 lines, -31 lines 0 comments Download
M media/base/cdm_promise.h View 2 chunks +0 lines, -4 lines 0 comments Download
M media/base/cdm_promise_adapter.h View 2 chunks +15 lines, -3 lines 0 comments Download
M media/base/cdm_promise_adapter.cc View 1 3 chunks +47 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
xhwang
More cleanup. PTAL https://codereview.chromium.org/836783004/diff/1/content/renderer/pepper/content_decryptor_delegate.cc File content/renderer/pepper/content_decryptor_delegate.cc (right): https://codereview.chromium.org/836783004/diff/1/content/renderer/pepper/content_decryptor_delegate.cc#newcode717 content/renderer/pepper/content_decryptor_delegate.cc:717: cdm_promise_adapter_.ResolvePromise(promise_id); The template type is automatically ...
5 years, 11 months ago (2015-01-09 23:51:03 UTC) #2
dmichael (off chromium)
pepper lgtm
5 years, 11 months ago (2015-01-12 17:54:29 UTC) #3
ddorwin
lgtm
5 years, 11 months ago (2015-01-12 18:24:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836783004/20001
5 years, 11 months ago (2015-01-13 01:13:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-13 02:06:49 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 02:07:50 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4f353712e360da935c67885a26befddafedb2f86
Cr-Commit-Position: refs/heads/master@{#311180}

Powered by Google App Engine
This is Rietveld 408576698