Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 836753005: Deleted ash/shelf/alternate_app_list_button.cc. (Closed)

Created:
5 years, 11 months ago by Matt Giuca
Modified:
5 years, 11 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deleted ash/shelf/alternate_app_list_button.cc. This file was unused since r263451 and it looks like it was accidentally not deleted. Committed: https://crrev.com/07816438a98fad0ff5728e7eedbb65161df9ccda Cr-Commit-Position: refs/heads/master@{#313191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -171 lines) Patch
D ash/shelf/alternate_app_list_button.cc View 1 chunk +0 lines, -171 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Matt Giuca
Looks like this should have been deleted in: https://codereview.chromium.org/229453005 (which deleted its header file, its ...
5 years, 11 months ago (2015-01-14 06:59:26 UTC) #2
Matt Giuca
+skuhne as reviewer.
5 years, 11 months ago (2015-01-27 00:21:30 UTC) #4
Mr4D (OOO till 08-26)
Yippieh! Code is gone! LGTM!
5 years, 11 months ago (2015-01-27 00:28:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836753005/1
5 years, 11 months ago (2015-01-27 00:36:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 01:28:14 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 01:30:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07816438a98fad0ff5728e7eedbb65161df9ccda
Cr-Commit-Position: refs/heads/master@{#313191}

Powered by Google App Engine
This is Rietveld 408576698