Issue 836723006: Improve the appearance of <sky-checkbox>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 836723006: Improve the appearance of <sky-checkbox> (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
eseidel, ojan

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Improve the appearance of <sky-checkbox> The unicode char never showed up for me, lets do what polymer does for now. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8afd38cefb7949f18c9440ee55140c4261f63bf1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -18 lines)			Patch
M	sky/examples/widgets/index.sky	View	2 chunks	+12 lines, -4 lines	0 comments	Download
M	sky/framework/sky-box/sky-box.sky	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	sky/framework/sky-checkbox/sky-checkbox.sky	View	2 chunks	+48 lines, -10 lines	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

Commit queue rejected this change because it did not recognize the base URL. Please commit ...

5 years, 11 months ago (2015-01-05 22:22:41 UTC) #6

esprehn

5 years, 11 months ago (2015-01-05 22:28:23 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8afd38cefb7949f18c9440ee55140c4261f63bf1 (presubmit successful).