Add a new function for getting a deterministic machine ID

chrome/browser/prefs/tracked/device_id_unittest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/prefs/tracked/device_id.h"
+#include "build/build_config.h"

[gab, 2015/01/26 19:40:46]

Sort.

[alito, 2015/01/26 21:01:11]

Done.

+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace tracked_prefs {
+
+TEST(GetDeterministicMachineSpecificIdTest, IsDeterministic) {
+  std::string first_machine_id;
+  std::string second_machine_id;
+
+  const MachineIdStatus kExpectedStatus =
+#if defined(OS_WIN)
+    SUCCESS;
+#else
+    NOT_IMPLEMENTED;
+#endif
+
+  ASSERT_EQ(kExpectedStatus,
+            GetDeterministicMachineSpecificId(&first_machine_id));
+  ASSERT_EQ(kExpectedStatus,
+            GetDeterministicMachineSpecificId(&second_machine_id));
+
+  EXPECT_EQ(kExpectedStatus != SUCCESS, first_machine_id.empty());

[gab, 2015/01/26 19:40:46]

I would flip this around (i.e. verify what should happen when success is
expected -- positive conditionals are prefered when it's an option)

[alito, 2015/01/26 21:01:11]

Done.

+  EXPECT_EQ(first_machine_id, second_machine_id);
+}
+
+}  // namespace tracked_prefs