chrome/browser/prefs/tracked/device_id_stub.cc - Issue 836703005: Add a new function for getting a deterministic machine ID

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/prefs/tracked/device_id_stub.cc

Issue 836703005: Add a new function for getting a deterministic machine ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/prefs/tracked/device_id.h ('K') | « chrome/browser/prefs/tracked/device_id.h ('k') | chrome/browser/prefs/tracked/device_id_unittest.cc » ('j') | chrome/browser/prefs/tracked/device_id_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "device_id.h"
	gab 2015/01/26 19:40:46 Use full path. Use full path. alito 2015/01/26 21:01:10 Done. Show quoted text On 2015/01/26 19:40:46, gab wrote: > Use full path. Done.
	6

	7 namespace tracked_prefs {

	8

	9 MachineIdStatus GetDeterministicMachineSpecificId(std::string *machine_id) {

	10 DCHECK(machine_id);

	11
	gab 2015/01/26 19:40:46 rm empty line (general rule is to reduce vertical rm empty line (general rule is to reduce vertical space to a minimum unless it improves readability). alito 2015/01/26 21:01:10 Done. Show quoted text On 2015/01/26 19:40:46, gab wrote: > rm empty line (general rule is to reduce vertical space to a minimum unless it > improves readability). Done.
	12 return NOT_IMPLEMENTED;

	13 }

	14

	15 }

OLD	NEW