chrome/browser/prefs/tracked/device_id_stub.cc - Issue 836703005: Add a new function for getting a deterministic machine ID

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/prefs/tracked/device_id_stub.cc

Issue 836703005: Add a new function for getting a deterministic machine ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/prefs/tracked/device_id.h ('K') | « chrome/browser/prefs/tracked/device_id.h ('k') | chrome/browser/prefs/tracked/device_id_unittest.cc » ('j') | chrome/browser/prefs/tracked/device_id_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 package org.chromium.dummy;	5 #include "device_id.h"
gab 2015/01/20 15:34:12 You can use git cl upload --similarity=100 in orde You can use git cl upload --similarity=100 in order to not have the upload consider this a copy w/ modifications of an other file. (no big deal, just a tip) alito 2015/01/26 16:32:48 Acknowledged. Show quoted text On 2015/01/20 15:34:12, gab wrote: > You can use > git cl upload --similarity=100 > in order to not have the upload consider this a copy w/ modifications of an > other file. > > (no big deal, just a tip) Acknowledged.
6	6

7 /** Does nothing. */	7 bool GetDeterministicMachineSpecificId(std::string *machine_id) {

8 class Dummy {}	8 if (!machine_id)

	9 return false;

9	10

	11 machine_id->clear();

	12

	13 return false;
	gab 2015/01/20 15:34:12 I think this should just return false (or the enum I think this should just return false (or the enum value for "not implemented"). alito 2015/01/26 16:32:48 Done. Show quoted text On 2015/01/20 15:34:12, gab wrote: > I think this should just return false (or the enum value for "not implemented"). Done.
	14 }

OLD	NEW